Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a language server working #1

Open
bollwyvl opened this issue Dec 9, 2022 · 2 comments
Open

Get a language server working #1

bollwyvl opened this issue Dec 9, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 9, 2022

Elevator Pitch

At least one language server should work.

Motivation

Not very fun otherwise.

Design Ideas

  • yaml-language-server seems like it's getting close,
    • but anything, really, that demos
@qqdaiyu55
Copy link

It will be HUGE if we can use jupyterlab-lsp on jupyterlite. Very promising! THANKS!

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Oct 8, 2023

There is now a final version of jupyterlab-lsp 5.0.0 available, so this work could continue, as it will now be possible to install a mutually-compatible constellation of jupyterlab, jupyterlite-core, and jupyterlite-lsp (previously, jupyterlab-lsp decided to go 3.6+, which jupyterlite didn't adopt, due to breaking changes, only now partially resolved in the 0.2.x line).

It would be ideal if the yaml-language-server revved its underlying dependencies so we weren't working with outdated LSP specs.

Once a single, out-of-kernel language server works, it might be another slog to get something working against a non-trivial kernel storage (e.g. not synced to contents). One way I can imagine is by something like jupyter-lsp/jupyterlab-lsp#278, which moves the JSON-RPC pipe from a dedicated mock "websocket" to Jupyter comms, but that branch is very bitrotted at this point, and might require even more monkeypatching craziness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants