Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug jupyter-releaser issue #561

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

krassowski
Copy link
Contributor

References

#558

Code changes

Just blindly checking if changing this could have an impact

User-facing changes

None

Backwards-incompatible changes

None

@krassowski
Copy link
Contributor Author

Oh, check-release is not running on PRs until they are closed due to this commit: 51ca23c

@krassowski
Copy link
Contributor Author

krassowski commented Nov 15, 2024

This exposed an error ValueError: @jupyterlab/scheduler is missing 'main' file lib/index.js

Nevermind...

@krassowski
Copy link
Contributor Author

Nope, this did not help at all:

image

@krassowski
Copy link
Contributor Author

It is quite intriguing as other repositories do not experience this issue, but I cannot put any more time into it this week.

I am able to reproduce it locally too. I enabled logging by editing jupyter-releaser code locally but nothing come up in there.

A laborious but possibly more fruitful approach to debugging it would be starting from a fresh cookiecutter and moving over parts of jupyter-scheduler to see what causes this behaviour.

@andrii-i
Copy link
Collaborator

Thank you for looking into this @krassowski.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants