Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug jupyter-releaser issue #561

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
5 changes: 3 additions & 2 deletions .github/workflows/check-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:
pull_request:
branches:
- main
types: [closed]

permissions:
contents: write
Expand All @@ -15,12 +14,14 @@ jobs:
check_release:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- run: ls -al
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
- name: Check Release
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
- run: ls -al
- name: Upload Distributions
uses: actions/upload-artifact@v4
with:
Expand Down
31 changes: 0 additions & 31 deletions MANIFEST.in

This file was deleted.

12 changes: 0 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -128,17 +128,5 @@
"extension": true,
"outputDir": "jupyter_scheduler/labextension",
"schemaDir": "schema"
},
"jupyter-releaser": {
"hooks": {
"before-build-npm": [
"python -m pip install jupyterlab~=4.0",
"jlpm",
"jlpm build:prod"
],
"before-build-python": [
"jlpm clean:all"
]
}
}
}
27 changes: 12 additions & 15 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["hatchling>=1.3.1", "jupyterlab~=4.0"]
requires = ["hatchling>=1.5.0", "jupyterlab>=4.0.0,<5", "hatch-nodejs-version>=0.3.2"]
build-backend = "hatchling.build"

[project]
Expand Down Expand Up @@ -30,15 +30,6 @@ classifiers = [
"Programming Language :: Python :: 3.12",
]
dependencies = [
"jupyter_server>=1.6,<3",
"traitlets~=5.0",
"nbconvert~=7.0",
"pydantic>=1.10,<3",
"sqlalchemy>=2.0,<3",
"croniter~=1.4",
"pytz>=2023.3,<=2024.2",
"fsspec>=2023.6.0,<=2024.10.0",
"psutil~=5.9"
]

[project.optional-dependencies]
Expand Down Expand Up @@ -72,14 +63,15 @@ artifacts = ["jupyter_scheduler/labextension"]
"jupyter-config/nb-config" = "etc/jupyter/jupyter_notebook_config.d"

[tool.hatch.build.targets.sdist]
exclude = [".github"]
artifacts = ["jupyter_scheduler/labextension"]
exclude = [".github", "binder"]

[tool.hatch.build.hooks.jupyter-builder]
dependencies = ["hatch-jupyter-builder>=0.5"]
build-function = "hatch_jupyter_builder.npm_builder"
ensured-targets = [
"jupyter_scheduler/labextension/static/style.js",
"jupyter_scheduler//labextension/package.json",
"jupyter_scheduler/labextension/package.json",
]
skip-if-exists = ["jupyter_scheduler/labextension/static/style.js"]

Expand Down Expand Up @@ -144,6 +136,14 @@ filterwarnings = [
[tool.jupyter_releaser]
skip = ["check-links"]

[tool.jupyter-releaser.hooks]
before-build-npm = [
"python -m pip install 'jupyterlab>=4.0.0,<5'",
"jlpm",
"jlpm build:prod"
]
before-build-python = ["jlpm clean:all"]

[tool.mypy]
check_untyped_defs = true
disallow_incomplete_defs = true
Expand All @@ -155,6 +155,3 @@ strict_equality = true
warn_unused_configs = true
warn_unused_ignores = true
warn_redundant_casts = true

[tool.check-manifest]
ignore = ["binder/**", "packages/**", "*.json", "*.png", "yarn.lock", ".*", "jupyter_scheduler/labextension/**", "jupyter_scheduler/static/**"]
Loading