Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better logic to set webpack public path in AMD modules #3508

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Better logic to set webpack public path in AMD modules #3508

merged 1 commit into from
Jul 6, 2022

Commits on Jul 6, 2022

  1. Better logic to set webpack public path in AMD modules. 

    Fixes jupyter-widgets#3474.

This is another take on jupyter-widgets#3464, since that approach did not work to set the public path in AMD modules. Essentially, since AMD modules are executed asynchronously, the webpack 'auto' public path logic does not work. Instead, we use the requirejs-specific 'module' magic dependency, which allows us to get the path to the current AMD module, and use that to get the public path. We do this public path computation in a separate script to isolate it from any library code.
    @jasongrout
    jasongrout committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    803cc66 View commit details
    Browse the repository at this point in the history