Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A collection of minor updates for 2022 #179

Merged
merged 6 commits into from
Jun 17, 2022

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Jun 16, 2022

This also contains a couple of fixes for ipywidgets 8. Closes #177

@mwcraig mwcraig added the 2020 Issues to be fixed for SciPy 2020 label Jun 16, 2022
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch mwcraig/tutorial/updates-for-8

@marimeireles
Copy link
Member

On it! :)

@marimeireles
Copy link
Member

marimeireles commented Jun 16, 2022

Hey @mwcraig is not working at all for me.
I had a problem with couldn't find version 0.2.19 of voila so I changed to the latest voila==0.3.5 and had a lot of conflicts. Changed back to 0.2.10 and looks fine. We surely need the 2.19?

@marimeireles marimeireles self-requested a review June 16, 2022 18:49
@ianhi
Copy link
Contributor

ianhi commented Jun 16, 2022

The readme claims that:

The installation instructions were tested on an up-to-date version of Windows 10 Professional. If you encounter any issues on Windows please open an issue or contact us through slack.

Is that actually true? Does anyone have windows on which to test this?

environment.yml Outdated
- requests
- scikit-image
- scipy
- sidecar=0.5.1
- voila=0.2.10
- voila=0.2.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last in the 0.2.x series is 16

Suggested change
- voila=0.2.19
- voila=0.2.16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- ended up changing it to 0.3.5 and dropping voila-vuetify and voila-material

- ipyleaflet=0.14.0
- ipympl=0.7.0
- ipyleaflet=0.16.0
- ipympl=0.9.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will need to make a new release of ipympl if we switch to ipywidgets 8. The current release has a gate on ipywidgets<8.
I started work on that here: matplotlib/ipympl#461 but stalled out bc I couldn't get the tests all passing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these will need new releases for ipywidgets 8 -- the pins should make sure that no one gets an 8-only package.

One reason for setting the goal of presenting in 8 is to help work through the remaining issue.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mwcraig
Copy link
Contributor Author

mwcraig commented Jun 17, 2022

Hey @mwcraig is not working at all for me. I had a problem with couldn't find version 0.2.19 of voila so I changed to the latest voila==0.3.5 and had a lot of conflicts. Changed back to 0.2.10 and looks fine. We surely need the 2.19?

Thanks -- it turns out we can use 0.3.5 if we drop voila-vuetify, which I think is fine, so I made that change.

@mwcraig
Copy link
Contributor Author

mwcraig commented Jun 17, 2022

The readme claims that:

The installation instructions were tested on an up-to-date version of Windows 10 Professional. If you encounter any issues on Windows please open an issue or contact us through slack.

Is that actually true? Does anyone have windows on which to test this?

It will be in about 30 minutes -- I have a windows 10 VM on my work laptop.

@mwcraig mwcraig merged commit 1bbbf79 into jupyter-widgets:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2020 Issues to be fixed for SciPy 2020
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix installations errors
3 participants