Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting testing latest ipywidgets + remove <8 pin #461

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

ianhi
Copy link
Collaborator

@ianhi ianhi commented Apr 15, 2022

Should fix #460

@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch ianhi/ipympl/widgets8

@ianhi
Copy link
Collaborator Author

ianhi commented Apr 15, 2022

@martinRenou I consolidated a lot of the tests because we were spending a lot of time waiting for conda envs to install so i figured we could save on that by just having build and test steps. Is there a reason that we should instead keep the separate?

@ianhi ianhi force-pushed the widgets8 branch 2 times, most recently from df34808 to 9ca5b67 Compare April 15, 2022 18:41
@martinRenou
Copy link
Member

Is there a reason that we should instead keep the separate?

The idea behind this is to test the generated wheel while running the tests. Though I am not strongly against getting rid of it.

@ianhi
Copy link
Collaborator Author

ianhi commented Apr 19, 2022

Is there a reason that we should instead keep the separate?

The idea behind this is to test the generated wheel while running the tests. Though I am not strongly against getting rid of it.

I think that that behavior was is maintained here - we still have a separate build and test step. I meant that the pytest tests and the visual regression tests were split into different steps which resulted in extra full installs

@ianhi
Copy link
Collaborator Author

ianhi commented Apr 20, 2022

notes for myself:

Check out the matrix of jupyterlab dependencies. Part of the issue may be due to this:

          - python: '3.6'
            dist: 'ipympl*.tar.gz'
            jlab_version: 3
          - python: '3.9'
            dist: 'ipympl*.whl'
            jlab_version: 2.3.2

there's also this warning: LOG Run-time JupyterLab version (3.3.4) is different than testing framework is built for (3.0.11). This could cause issues in testing.

@martinRenou
Copy link
Member

We need to update Galata quite a bit probably. I'll do this in this PR if it does not pass the tests.

@martinRenou
Copy link
Member

martinRenou commented Aug 19, 2022

The failing tests are the ones against Matplotlib's main branch, so we can ignore them for now and fix those later.

@martinRenou martinRenou marked this pull request as draft August 19, 2022 10:58
@martinRenou martinRenou force-pushed the widgets8 branch 3 times, most recently from 5356b7a to 22dc2e1 Compare August 19, 2022 12:45
@martinRenou
Copy link
Member

Please update galata references

@martinRenou
Copy link
Member

@martinRenou martinRenou marked this pull request as ready for review August 22, 2022 09:18
@martinRenou
Copy link
Member

martinRenou commented Aug 22, 2022

I removed the JupyterLab 2 CI test, as it's quite old anyway now and it reduces our build matrix.

As said above, the tests against latest Matplotlib are failing, let's ignore those for now.

Merging!

@martinRenou martinRenou merged commit eb3d3dc into matplotlib:main Aug 22, 2022
@ianhi
Copy link
Collaborator Author

ianhi commented Aug 22, 2022

thank you martin!

@ianhi ianhi deleted the widgets8 branch August 22, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to load model class 'MPLCanvasModel' from module 'jupyter-matplotlib'
2 participants