-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting testing latest ipywidgets + remove <8
pin
#461
Conversation
@martinRenou I consolidated a lot of the tests because we were spending a lot of time waiting for conda envs to install so i figured we could save on that by just having |
df34808
to
9ca5b67
Compare
The idea behind this is to test the generated wheel while running the tests. Though I am not strongly against getting rid of it. |
I think that that behavior was is maintained here - we still have a separate |
notes for myself: Check out the matrix of jupyterlab dependencies. Part of the issue may be due to this:
there's also this warning: |
We need to update Galata quite a bit probably. I'll do this in this PR if it does not pass the tests. |
The failing tests are the ones against Matplotlib's main branch, so we can ignore them for now and fix those later. |
5356b7a
to
22dc2e1
Compare
Please update galata references |
I removed the JupyterLab 2 CI test, as it's quite old anyway now and it reduces our build matrix. As said above, the tests against latest Matplotlib are failing, let's ignore those for now. Merging! |
thank you martin! |
Should fix #460