Skip to content

Commit

Permalink
Pin min notebook version (#2167)
Browse files Browse the repository at this point in the history
* [TMP] Pin min notebook version

* Update Dockerfile
  • Loading branch information
mathbunnyru authored Nov 4, 2024
1 parent 5841857 commit c2d9d1f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 5 additions & 1 deletion images/base-notebook/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ RUN mamba install --yes \
'jupyterhub' \
'jupyterlab' \
'nbclassic' \
'notebook' && \
# Sometimes, when the new version of `jupyterlab` is released, latest `notebook` might not support it for some time
# Old versions of `notebook` (<v7) didn't have a restriction on the `jupyterlab` version, and old `notebook` is getting installed
# That's why we have to pin the minimum notebook version
# More info: https://github.com/jupyter/docker-stacks/pull/2167
'notebook>=7.2.2' && \
jupyter server --generate-config && \
mamba clean --all -f -y && \
npm cache clean --force && \
Expand Down
1 change: 1 addition & 0 deletions tests/docker-stacks-foundation/test_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"hdf5",
"jupyterlab-git",
"mamba[version='<2.0.0']",
"notebook[version='>",
"openssl",
"pandas[version='>",
"protobuf",
Expand Down

0 comments on commit c2d9d1f

Please sign in to comment.