Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin min notebook version #2167

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

jupyterlab 4.3.0 has been released, but the new notebook which supports this version hasn't yet.

Unfortunately, previous versions of notebook (<v7) didn't have a version restriction on jupyterlab, so the solver installs jupyterlab 4.3.0 and notebook 6.5.7 (and obviously it doesn't work)

To fix this problem, I decided to pin the minimum notebook version.
We might need to keep this pin forever so we don't have the same problem with new releases of jupyterlab.

@krassowski @minrk @bollwyvl do you maybe know a better solution?

@mathbunnyru mathbunnyru changed the title [TMP] Pin min notebook version Pin min notebook version Nov 4, 2024
@mathbunnyru
Copy link
Member Author

Merging this, because currently, our builds are failing.
Please let me know, if there is a better solution.

@mathbunnyru mathbunnyru merged commit c2d9d1f into jupyter:main Nov 4, 2024
5 of 37 checks passed
benz0li added a commit to b-data/jupyterlab-r-docker-stack that referenced this pull request Nov 5, 2024
- base: Rollback JupyterLab to v4.2.5
- jupyter/docker-stacks#2167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant