Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the custom env recipe to correctly activate it by default #1975

Merged
merged 5 commits into from
Aug 20, 2023

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Fix: #1903

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

mathbunnyru commented Aug 20, 2023

@creative-resort please, check, if this works for you.

Comment on lines +4 to +5
ARG env_name=python310
ARG py_ver=3.10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.8 also works fine.
I updated these lines to make sure 3.10 also works.
And this recipe will stay up-to-date a bit longer (till 3.10 reaches eol).

@mathbunnyru
Copy link
Member Author

I've checked it on my machine and it seems to work well.
@creative-resort please, tell me if you encounter any issues.
I will merge this PR (and close the issue), because I will need this updated recipe to fix another issue as well.

@mathbunnyru mathbunnyru merged commit b88eba3 into jupyter:main Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] - include conda env activation for kernel with custom environment
1 participant