Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the custom env recipe to correctly activate it by default #1975

Merged
merged 5 commits into from
Aug 20, 2023
Merged

Update the custom env recipe to correctly activate it by default #1975

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e52f579
Update the custom env recipe to correctly activate it by default
mathbunnyru Aug 20, 2023
e50f209
Merge branch 'main' into asalikhov/custom_env_recipe
mathbunnyru Aug 20, 2023
ec37d26
Merge branch 'main' into asalikhov/custom_env_recipe
mathbunnyru Aug 20, 2023
7abed29
Remove obsolete line
mathbunnyru Aug 20, 2023
627563c
Better wording
mathbunnyru Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions docs/using/recipe_code/custom_environment.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
FROM jupyter/base-notebook

# Name your environment and choose the python version
ARG env_name=python38
ARG py_ver=3.8
ARG env_name=python310
ARG py_ver=3.10
Comment on lines +4 to +5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.8 also works fine.
I updated these lines to make sure 3.10 also works.
And this recipe will stay up-to-date a bit longer (till 3.10 reaches eol).


# You can add additional libraries here
RUN mamba create --yes -p "${CONDA_DIR}/envs/${env_name}" \
Expand All @@ -28,6 +28,17 @@ RUN "${CONDA_DIR}/envs/${env_name}/bin/python" -m ipykernel install --user --nam
RUN "${CONDA_DIR}/envs/${env_name}/bin/pip" install --no-cache-dir \
'flake8'

# If you do not want this environment to be the default one, comment this line
# hadolint ignore=DL3059
# Creating a startup hook, which will activate our custom environment by default in Jupyter Notebook
# More info about startup hooks: https://jupyter-docker-stacks.readthedocs.io/en/latest/using/common.html#startup-hooks
# You can comment this section to keep the default environment in Jupyter Notebook
USER root
RUN activate_custom_env_script=/usr/local/bin/before-notebook.d/activate_custom_env.sh && \
echo "#!/bin/bash" > ${activate_custom_env_script} && \
echo "eval \"$(conda shell.bash activate "${env_name}")\"" >> ${activate_custom_env_script} && \
chmod +x ${activate_custom_env_script}

USER ${NB_UID}

# Making this environment default in Terminal
# You can comment this line to keep the default environment in Terminal
RUN echo "conda activate ${env_name}" >> "${HOME}/.bashrc"