Remove some deprecated zmq imports #842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
force-pushed
the
deprecated-zmq-imports
branch
from
9233c85
to
ce040ab
Compare
The zmq.eventloop.ioloop shim has been deprecated since pyzmq 17
minrk
force-pushed
the
deprecated-zmq-imports
branch
from
ce040ab
to
50103e6
Compare
|
Can wait to finish after the big refactor in #835, to avoid conflicts. |
|
This is now unblocked, but has conflicts as predicted |
|
Any progress on this one? Now, Thanks a lot for all your hard work! |
|
I think I need to start from a new PR, the merge resolve is too messy. |
blink1073
added a commit
that referenced
this pull request
Jan 13, 2023
Closed
blink1073
added a commit
to blink1073/jupyter_client
that referenced
this pull request
Feb 27, 2024
closes jupyter#842 (cherry picked from commit 3161087)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zmq.eventloop.ioloop shim has been deprecated since pyzmq 17
jupyter-client requires pyzmq 23