Handle needs_background cell metadata (#1704)

This fixes issues when rendering Matplotlib figures with the HTMLExporter, lab template and dark theme
jupyter · Jan 17, 2022 · 8df914d · 8df914d
1 parent b645841
commit 8df914d
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/share/jupyter/nbconvert/templates/lab/base.html.j2 b/share/jupyter/nbconvert/templates/lab/base.html.j2
@@ -176,9 +176,17 @@ width={{ width }}
 {%- if height is not none %}
 height={{ height }}
 {%- endif %}
+class="
 {%- if output | get_metadata('unconfined', 'image/png') %}
-class="unconfined"
+unconfined
 {%- endif %}
+{%- if output | get_metadata('needs_background', 'image/png') == 'light' %}
+jp-needs-light-background
+{%- endif %}
+{%- if output | get_metadata('needs_background', 'image/png') == 'dark' %}
+jp-needs-dark-background
+{%- endif %}
+"
 >
 </div>
 {%- endblock data_png %}
@@ -198,9 +206,17 @@ width={{ width }}
 {%- if height is not none %}
 height={{ height }}
 {%- endif %}
+class="
 {%- if output | get_metadata('unconfined', 'image/jpeg') %}
-class="unconfined"
+unconfined
+{%- endif %}
+{%- if output | get_metadata('needs_background', 'image/jpeg') == 'light' %}
+jp-needs-light-background
+{%- endif %}
+{%- if output | get_metadata('needs_background', 'image/jpeg') == 'dark' %}
+jp-needs-dark-background
 {%- endif %}
+"
 >
 </div>
 {%- endblock data_jpg %}