Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle needs_background cell metadata #1704

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Handle needs_background cell metadata #1704

merged 1 commit into from
Jan 17, 2022

Conversation

martinRenou
Copy link
Member

This fixes issues when rendering Matplotlib figures with the HTMLExporter, lab template and dark theme.

Reproduce

import matplotlib.pyplot as plt
plt.plot([1, 2, 3, 4])
plt.ylabel('some numbers')
plt.show()
jupyter nbconvert --to html --HTMLExporter.theme=dark --HTMLExporter.template_name=lab Untitled.ipynb

Before

before

After

after

@martinRenou
Handle needs_background cell metadata
16094f1 
This fixes issues when rendering Matplotlib figures with the
HTMLExporter, lab template and dark theme
@martinRenou martinRenou mentioned this pull request Jan 12, 2022
Merged
@SylvainCorlay SylvainCorlay merged commit 8df914d into jupyter:main Jan 17, 2022
@martinRenou martinRenou deleted the handle_needs_background_metadata branch January 17, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @SylvainCorlay