-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix editor background color #714
Fix editor background color #714
Conversation
2ad3094
to
22688ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HaudinFlorence
a6407c6
to
84c13be
Compare
I have two questions here:
|
bot please update snapshots |
@krassowski Thanks for having a look at this PR.
In fact, locally the change was not visible in my labextension. Could you please check on your local one? Normally the backgorund should be taken into account because the changes are introduced in
I think it was only a matter of updating the snapshots. |
55010cf
to
dff5453
Compare
Well, if the tests were all green before updating the snapshots it strongly suggests that we should adjust Reference: https://playwright.dev/docs/api/class-pageassertions#page-assertions-to-have-screenshot-1 |
bot please update snapshots |
I am not completely sure that all tests were green. I take note about your suggestion. |
The windows snapshots seem to have been inadvertly deleted. bot please update playwright snapshots |
Playwright ubuntu-22.04 snapshots updated. |
Playwright windows-latest snapshots updated. |
...ests/nbdime-merge-test6.spec.ts-snapshots/merge-test6-take-a-snapshot-at-opening-1-linux.png
Show resolved
Hide resolved
Triggering the CI with the latest snapshots |
Good call, failed in tests. bot please update playwright snapshots |
Playwright ubuntu-22.04 snapshots updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @HaudinFlorence, snapshots look good now.
This PR aims at fixing the missing background color for the codemirror editors, to be aligned with jupyterlab cells' color (when unselected). It adresses the case of the webapp. The background is not yet fixed for the labextension.
The re-introduced background color is the one associated with the css variable
--jp-cell-editor-background
as can be seen on the following capture: