Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for the frontend in Lab #709

Merged
merged 8 commits into from
Oct 26, 2023

Conversation

fcollonval
Copy link
Collaborator

@fcollonval fcollonval commented Oct 11, 2023

Plug in the translation infrastructure of JupyterLab for the frontends.

@krassowski
Copy link
Member

krassowski commented Oct 20, 2023

Some untranslated strings I noticed from using the labextension:

@fcollonval
Copy link
Collaborator Author

Thanks Mike for looking at those

As you mentioned, some will be hard to solve like the one using the CSS content for hidden cells. And I'm uncomfortable to translate the collapsibleHeader as it is defined in the model - I prefer the translation to occur only in views. But I could probably go ahead as changing the code logic will be too large.

@fcollonval
Copy link
Collaborator Author

Thanks @krassowski after 6ccc4cc the element remaining in Lab is the unchanged cells as it is set in the CSS. The web apps template are also not covered as anyway it will require quite some work to add server support for handling the mo/json files.

@krassowski krassowski mentioned this pull request Oct 25, 2023
2 tasks
@krassowski
Copy link
Member

Thanks! I moved the remaining bits to #724 (comment).

The snapshots will need updating after the italics were removed. I would recommend merging with main to pickup #714 that I just merged to facilitate.

@fcollonval
Copy link
Collaborator Author

bot please update playwright snapshots

@github-actions
Copy link
Contributor

Playwright windows-latest snapshots updated.

@fcollonval
Copy link
Collaborator Author

Kicking the CI

@fcollonval fcollonval closed this Oct 26, 2023
@fcollonval fcollonval reopened this Oct 26, 2023
@krassowski
Copy link
Member

Seems only Windows snapshots were updated:
bot please update playwright snapshots

@github-actions
Copy link
Contributor

Playwright ubuntu-22.04 snapshots updated.

@krassowski krassowski closed this Oct 26, 2023
@krassowski krassowski reopened this Oct 26, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Case in point that the background changes are too subtle to be picked up @HaudinFlorence. The snapshot on the left was not updated in #714 and all tests were green because as highlighted in #714 (comment) the defaults are too lax to reject on subtle colour changes.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fcollonval!

@krassowski krassowski merged commit cbc57d2 into jupyter:master Oct 26, 2023
12 checks passed
@fcollonval fcollonval deleted the ft/add-translator branch October 26, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants