-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation for the frontend in Lab #709
Conversation
20807c2
to
0e93ec1
Compare
Some untranslated strings I noticed from using the labextension:
|
Thanks Mike for looking at those As you mentioned, some will be hard to solve like the one using the CSS |
3d6668f
to
6ccc4cc
Compare
Thanks @krassowski after 6ccc4cc the element remaining in Lab is the unchanged cells as it is set in the CSS. The web apps template are also not covered as anyway it will require quite some work to add server support for handling the mo/json files. |
Thanks! I moved the remaining bits to #724 (comment). The snapshots will need updating after the italics were removed. I would recommend merging with main to pickup #714 that I just merged to facilitate. |
6ccc4cc
to
6ea752c
Compare
bot please update playwright snapshots |
Playwright windows-latest snapshots updated. |
Kicking the CI |
Seems only Windows snapshots were updated: |
Playwright ubuntu-22.04 snapshots updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Case in point that the background changes are too subtle to be picked up @HaudinFlorence. The snapshot on the left was not updated in #714 and all tests were green because as highlighted in #714 (comment) the defaults are too lax to reject on subtle colour changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fcollonval!
Plug in the translation infrastructure of JupyterLab for the frontends.