Do not collapse editor lines in single editor #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot please update playwright snapshots |
|
Playwright windows-latest snapshots updated. |
|
Playwright ubuntu-22.04 snapshots updated. |
fcollonval
commented
Oct 18, 2023
krassowski
changed the title
krassowski
approved these changes
Oct 20, 2023
| <input id="compare-base" type="text" name="base" value="{{ config_data['base']|e }}" /> | ||
| <label>Remote:</label> | ||
| <input id="compare-remote" type="text" name="remote" value="{{ config_data['remote']|e }}" /> | ||
| <label>Local: |
There was a problem hiding this comment.
Keeping atomic labels with for="id" might make it easier to translate in the #709 but for the sake of this one it does not matter much.
| // no collapse | ||
| this._collapseIdentical >= 0 && | ||
| // not displaying a single editor | ||
| !singlePane |
There was a problem hiding this comment.
Note: tested locally to confirm that it also works for diff view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix partly #718 (it does not solve the notebook metadata unchanged case).