disable git shallow-clone #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in deploy. This is already in test-helm, but that’s harder to find since it has lots of output. and get nicer command headings for multi-line commands
so that updates must be made explicitly
can result in misidentified commits for images
betatim
reviewed
Apr 2, 2018
.travis.yml
Outdated
| if [[ "$TRAVIS_PULL_REQUEST" == "false" && "$TEST" == "helm" ]]; then | ||
| openssl aes-256-cbc -K $encrypted_d8355cc3d845_key -iv $encrypted_d8355cc3d845_iv -in travis.enc -out travis -d | ||
| chmod 0400 travis | ||
| export GIT_SSH_COMMAND="ssh -i ${PWD}/travis" | ||
| docker login -u ${DOCKER_USERNAME} -p "${DOCKER_PASSWORD}" | ||
| cd helm-chart | ||
| chartpress --commit-range "${TRAVIS_COMMIT_RANGE}" --push --publish-chart | ||
| git diff |
There was a problem hiding this comment.
should we add a comment saying what the expected output of git diff is when everything is fine?
|
(restarted travis as we had exceeded the GH API limit) |
|
There is no solution to the GitHub API limit issue other than not testing GitHub repos, since we can't make credentials accessible to pull requests. It should pass once merged, since master has a GitHub token. |
|
Merging this without waiting for travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as jupyterhub/zero-to-jupyterhub-k8s#621
shallow-clone can result in incorrect image tagging if image directories go without updates for a bit.
Additionally:
git diffafter chartpress for easier debugging