Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug chartpress, disable shallow-clone #621

Merged
merged 4 commits into from
Apr 2, 2018

Conversation

minrk
Copy link
Member

@minrk minrk commented Apr 1, 2018

  • run git diff after chartpress to show changes, in case something suspicious is in values.yaml
  • pin specific chartpress commit so that chartpress only changes explicitly (there's also a slight possibility of caching being responsible for the recent weird chartpress behavior in Failed to pull image "jupyterhub/k8s-network-tools:d6340ab" #612)
  • rerender values.yaml with recent changes that deviated slightly in style to avoid churn when chartpress rerenders values.yaml

closes #612

minrk added 3 commits April 1, 2018 10:56
avoids floating chartpress versions
should show changes from chartpress if they are suspicious
removes churn from chartpress roundtrip
@minrk minrk changed the title debug chartpress [WIP] debug chartpress Apr 1, 2018
@minrk
Copy link
Member Author

minrk commented Apr 1, 2018

chartpress is indeed getting the wrong commits for network-tools and singleuser-sample on Travis. The rest are correct. Interestingly enough, it's getting the right commits when I run it locally. Investigating...

avoids getting the wrong commits for images that haven’t been updated in a while
@minrk
Copy link
Member Author

minrk commented Apr 1, 2018

This was caused by shallow-cloning done by travis, which resulted in misidentifying the latest commits of images that haven't changed in a bit. Disabling the shallow-clone behavior has fixed the image tagging.

@minrk minrk changed the title [WIP] debug chartpress debug chartpress, disable shallow-clone Apr 1, 2018
@yuvipanda yuvipanda merged commit 7445e2e into jupyterhub:master Apr 2, 2018
@minrk minrk deleted the debug-chartpress branch April 3, 2018 09:38
@minrk minrk restored the debug-chartpress branch April 3, 2018 15:55
@manics manics mentioned this pull request Aug 15, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to pull image "jupyterhub/k8s-network-tools:d6340ab"
2 participants