Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some reflector references #201

Merged
merged 2 commits into from
Jul 3, 2018
Merged

Fix some reflector references #201

merged 2 commits into from
Jul 3, 2018

Conversation

minrk
Copy link
Member

@minrk minrk commented Jul 3, 2018

  • typo in avoid failure to delete pods that don’t exist #196 fix self.pods should have been self.pod_reflector.pods
  • fixes for event reflector:
    • call it self.event_reflector to match .pod_reflector
    • hold onto references to the reflector once retrieved to avoid errors when self.events is None.

minrk added 2 commits July 3, 2018 15:34
@minrk
pod_reflector typo
cfe72b6 
pod_reflector.pods not self.pods
@minrk
manage references to event_reflector
1ad3cbe 
avoid errors when `self.events` could be None by grabbing `self.event_reflector` reference once and reusing it

Improve consistency by calling the event reflector `.event_reflector` like `.pod_reflector` instead of `.events`
@minrk minrk merged commit f422420 into jupyterhub:master Jul 3, 2018
@minrk minrk deleted the 404-typo branch July 3, 2018 14:02
minrk referenced this pull request Jul 3, 2018
@minrk
Merge pull request #196 from minrk/stop-404
82e69f5 
avoid failure to delete pods that don’t exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@minrk