avoid failure to delete pods that don’t exist #196
Conversation
stopping could raise 404 if it doesn’t exist (e.g. already deleted). Log this as a warning instead of raising.
There was a problem hiding this comment.
Wieee!!!
Does this mean that if a node is deleted (because we used preemptible nodes for example), the users on the node will be able to respawn later and not get into trouble? =D
Been looking to fix that before but did not feel like a good issue for me to tackle since there was so much uncharted domains for me.
This looks good to me, as far as i can tell.
|
I'm not sure exactly what cases could cause this. An evicted pod shouldn't result in this failure, since the pod still 'exists' and delete shouldn't fail. I think this can only occur due to a bug where we are calling delete twice (or someone else called delete manually). |
|
@minrk ah thanks for reasoning about this with me! That is probably what I've experienced rather than an unexpected node shutdown. |
stopping could raise 404 if it doesn’t exist (e.g. already deleted). Log this as a warning instead of raising.