Don’t trust pod reflector when deciding whether to delete #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If pod reflector hasn’t noticed this pod yet, removal won’t be attempted, leading to a leak in pods. Instead, just attempt deletion and handle the 404 if it’s really not there.
|
@minrk we're running into a "culling runaway" failure mode again, which I think this would fix, yes? Should we just merge this and deploy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pod reflector hasn’t noticed this pod yet, removal won’t be attempted, leading to a leak in pods.
Instead, just attempt deletion and handle the 404 if it’s really not there.
This exacerbates a failure mode where the pod_reflector starts missing events because pods that start but aren't noticed will be believed to be not running and won't be deleted.
This optimization was introduced in #196, but isn't worth the cost.