Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin_groups to grant admin access to users of these groups #198

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Vendetta01
Copy link

This PR adds a new configuration option admin_groups, to grant admin access to all users that are members of these groups and thus lets you define admin access through ldap group membership. Its implementation is similar to allowed_groups.

This fixes #160.

Vendetta01 and others added 3 commits May 29, 2021 13:11
Added tests and fixed admin flag not returned if user_info is not set.
@welcome
Copy link

welcome bot commented Jun 12, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@firemdkfighter
Copy link

firemdkfighter commented Aug 3, 2021

When this PR will be merged?

@Yayg
Copy link

Yayg commented Sep 24, 2021

👍 for getting this merged! Thanks for the contribution

@mrdrelar
Copy link

mrdrelar commented Jan 19, 2022

plus for this PR. When it will be merged?

@consideRatio consideRatio mentioned this pull request Jun 4, 2023
12 tasks
@consideRatio consideRatio changed the title Add admin_group to grant admin access to users of these groups Add admin_groups to grant admin access to users of these groups Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specifiy admin user via ldap
5 participants