Organize into multiple files #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow LTILaunchValidator to be used without needing to use all the JupyterHub related things! - Use a specific LTLaunchValidationError than just web.HTTPError
minrk
reviewed
Feb 13, 2018
| user = yield self.login_user() | ||
| self.redirect(self.get_body_argument('custom_next', self.get_next_url())) | ||
| from .auth import LTIAuthenticator | ||
| from .validator import LTILaunchValidator, LTILaunchValidationError |
There was a problem hiding this comment.
If you omit the from .auth import LTIAuthenticator here in __init__, instead requiring users to explicitly import litauthenticator.validator or ltiauthenticator.auth, then the validator may be used without jupyterhub being importable.
That's a backward-incompatible change in terms of imports, but a minor one.
This was referenced Mar 14, 2021
Merged
|
@yuvipanda should we close this now that we have the refactor done with #41 ? |
|
@consideRatio would you agree on closing this PR since the merge from #44 effectively updated the master branch with these changes? |
|
Yep, let's close this. Thanks, @jgwerner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the JupyterHub related things!