Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit and formatting tools #40

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Add pre-commit and formatting tools #40

merged 2 commits into from
Apr 8, 2021

Conversation

jgwerner
Copy link
Collaborator

@jgwerner jgwerner commented Mar 14, 2021

  • Adds Flake8 linter
  • Adds black for code formatting
  • Adds pre-commit config
  • Adds Contributing guide

Related to #38 and #39

Signed-off-by: Greg Werner <werner.greg@gmail.com>
@jgwerner
Copy link
Collaborator Author

@yuvipanda as soon as you merge this PR I'll send one to refactor the existing LTI 1.1 setup based on #2 and then will add a separate one for LTI 1.3.

@jgwerner jgwerner mentioned this pull request Mar 14, 2021
@jgwerner
Copy link
Collaborator Author

@yuvipanda I submitted #41 as a preview to this merge. I'll rebase once it's time to merge.

Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! One minor comment, otherwise happy to merge :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Greg Werner <werner.greg@gmail.com>
@jgwerner
Copy link
Collaborator Author

jgwerner commented Apr 8, 2021

@yuvipanda the comment regarding semantic versioning has been removed.

@yuvipanda yuvipanda merged commit a02d4ac into jupyterhub:master Apr 8, 2021
@welcome
Copy link

welcome bot commented Apr 8, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@yuvipanda
Copy link
Collaborator

w00t, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants