Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cull_idle fails for some users with non ascii usernames #573

Closed
chicocvenancio opened this issue Mar 12, 2018 · 0 comments
Closed

Cull_idle fails for some users with non ascii usernames #573

chicocvenancio opened this issue Mar 12, 2018 · 0 comments

Comments

@chicocvenancio
Copy link
Contributor

At the moment Cull Idle queries the API for the users with inactive running servers and sends a DELETE to the endpoint users/USERNAME/server.

zero-to-jupyterhub-k8s/images/hub/cull_idle_servers.py

Line 69 in 706a8f7

req = HTTPRequest(url=url + '/users/%s/server' % user['name'],
This works for most users, but fails with users with non ASCII usernames as the api responds with a 404.

By url-encoding the username we can make sure it works for every user.
chicocvenancio added a commit to chicocvenancio/zero-to-jupyterhub-k8s that referenced this issue Mar 12, 2018
@chicocvenancio
use urllib quote to encode username in culler FIX jupyterhub#573
10de8dc
@chicocvenancio chicocvenancio mentioned this issue Mar 12, 2018
Merged
minrk added a commit that referenced this issue Mar 13, 2018
@minrk
Merge pull request #574 from chicocvenancio/encode_url_culler
878a961 
use urllib quote to encode username in culler FIX #573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chicocvenancio