Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use urllib quote to encode username in culler FIX #573 #574

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

chicocvenancio
Copy link
Contributor

@chicocvenancio chicocvenancio commented Mar 12, 2018

Closes #573

@chicocvenancio
Copy link
Contributor Author

Fwiw, I tested this and it kept working with usernames with ascii characters and started working with usernames with non-ascii characters chicocvenancio/paws@9a77d1d

@consideRatio
Copy link
Member

I get this happy feeling about the code base when I think of how many is participating in testing it and contributing to it!

@minrk minrk merged commit 878a961 into jupyterhub:master Mar 13, 2018
@minrk
Copy link
Member

minrk commented Mar 13, 2018

Thanks! This should be right. Since JupyterHub itself doesn't support Python 2 (3.5 for 0.9, 3.3 for 0.8), I don't think we need to support Python 2 in example scripts, but there's no harm in having an import check like this.

@manics manics mentioned this pull request Aug 15, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants