-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to reflect Azure 2022 process #2823
Update docs to reflect Azure 2022 process #2823
Conversation
The autoscaling feature is now in production and can be enabled with a single flag. This has been incorporated into the main azure docs.
… of VM node sizes
…eprecated and only appId should be used. Update the docs accordingly. [1]: Azure/azure-cli#19179 (comment)
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
There's a broken link outside of the scope of this PR that is responsible for failed checks:
|
@Sieboldianus wieeee thank you for helping out with this! I'm very positive on combining both the separate documents into one as that added significant complexity with regards to maintaining this documentation. I'll try find time to review this tonight, but a key review point in my mind will be: was something of relevance lost when we removed one of the versions of the azure setup that should be retained in the one we keep? |
I can check again in detail, but it mostly looked duplicate, except for the preview-feature part (which isn't necessary anymore). I'll also want to look into the part again for activating autoscale for an existing cluster, just to make sure it works as written. Thank you for reviewing this. Thanks for the great docs! |
Originally `--enable-vmss`, changed to `--vm-set-type`, see [jupyterhub#927](927) 927: Azure/azure-cli-extensions#927 (comment)
@consideRatio: I went through the docs again and compared the autoscaler to the standard docs and merged all.
I think it makes sense merging both docs, since the differences between autoscaling and not autoscaling for a cluster are minimal, but I am new to the project and not the best to decide. |
After installing a helm chart, kubectl outputs the command to get the public IP of the proxy. This should be used as a default in the docs: You can find the public (load-balancer) IP of JupyterHub by running: > kubectl -n ... get svc proxy-public -o jsonpath='{.status.loadBalancer.ingress[].ip}' > > It might take a few minutes for it to appear\!
While I was at it, I also updated Installing JupyterHub: Getting the public IP of the Proxy (7ff31fd).
This does not really fit in here. Happy to submit a different PR for this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Sieboldianus !!!! ❤️ 🎉
I recently went through the Kubernetes on Microsoft Azure Kubernetes Service (AKS) and Kubernetes on Microsoft Azure Kubernetes Service (AKS) with Autoscaling docs.
There were some minor inconsistencies with the current Azure process that I have updated.