Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add informational fields and minimal comments to jupyterhub chart #557

Merged
merged 3 commits into from
Mar 6, 2018

Conversation

willingc
Copy link
Collaborator

@willingc willingc commented Mar 3, 2018

Addresses #556.

  • Adds additional information fields to Chart.yaml
  • Adds minimal descriptions to values.yaml (See Chart Best Practices)

@willingc willingc requested a review from yuvipanda March 3, 2018 22:00
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! I bet these will help a lot of newcomers as I figure they would have helped me a lot getting started!

I considered if we should add even more details, for example under "prePuller", what does hook and continuous mean? But, I think that level of helpful commenting might be a bit too much. The docs should not be duplicated, so where do you draw the line? I like where you have drawn the line!

@choldgraf
Copy link
Member

this is great! thanks!

@choldgraf
Copy link
Member

oops! accidentally merged before realizing that tests weren't passing. I've reverted, so maybe you can re-open this PR so we can figure out what's up?

Here's the error:

helm install --name jupyterhub-test --namespace jupyterhub-test ./jupyterhub/ -f minikube-config.yaml
Error: error unmarshaling JSON: json: cannot unmarshal array into Go struct field Metadata.home of type string

@manics manics mentioned this pull request Aug 15, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants