Fix modifyCell or modifyEditor not called after text editor is opened after notebook

[firai]

Fixes #103.

On ILabShell currentChanged(), check if currentWidget matches one tracked by editorTracker or notebookTracker, and call modifyEditor() or modifyCell() accordingly.

@krassowski, can you please help review whether this is right approach?

[github-actions]

👈 Launch a Binder on branch firai/jupyterlab-vim/modifyCell-when-changing-active-widget

[krassowski]

Yes, in principle it looks right, though I would avoid console.warn in final version to keep the dev console usable. Does it fix the problem?

[firai]

Yes, as far as I can tell. The code block and the console.warn were copied from here:

jupyterlab-vim/src/index.ts

Lines 87 to 104 in f08ef41

	app.commands.addCommand('vim:enter-normal-mode', {
	label: 'Enter Normal Vim Mode',
	execute: () => {
	const current = app.shell.currentWidget;
	if (!current) {
	console.warn('Current widget not found');
	} else if (editorTracker.currentWidget === current) {
	editorManager.modifyEditor(editorTracker.currentWidget.content.editor);
	} else if (notebookTracker.currentWidget === current) {
	cellManager.modifyCell(
	notebookTracker.currentWidget.content.activeCell
	);
	} else {
	console.warn('Current widget is not vim-enabled');
	}
	},
	isEnabled: () => enabled
	});

Do you have any suggestions on what the console.warn should be replaced with? Also, I suppose I'm supposed to refactor this out into a function so that it isn't duplicated?

[krassowski]

Well, the difference is that when vim:enter-normal-mode is run we expect the current widget to be vim-enabled, but shell.currentChanged will fire for any kind of a widget. I would say you could use console.debug or just remove it (if you want to leave the logic for clarity you can add // no-op comment).

IMO duplication is fine as these are slightly different contexts.

[firai]

The build process fails without the if (!current) code path, so I'll replace with no-op comments

[krassowski]

Thank you @firai. Tested on binder, works well.