Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modifyCell or modifyEditor not called after text editor is opened after notebook #105

Merged
merged 9 commits into from
Sep 3, 2023
Merged

Fix modifyCell or modifyEditor not called after text editor is opened after notebook #105

merged 9 commits into from
Sep 3, 2023

Commits on Sep 3, 2023

  1. Connect notebookTracker currentChanged to editorManager

    @firai
    firai authored Sep 3, 2023
    Configuration menu
    Copy the full SHA
    1e3c66d View commit details
    Browse the repository at this point in the history

  2. Connect notebookTracker currentChanged to cellManager rather than edi… 

    …torManager
    @firai
    firai authored Sep 3, 2023
    Configuration menu
    Copy the full SHA
    df79626 View commit details
    Browse the repository at this point in the history

  3. Find current widget and then modifyCell rather than directly connecti… 

    …ng signal to manager
    @firai
    firai authored Sep 3, 2023
    Configuration menu
    Copy the full SHA
    99b7f08 View commit details
    Browse the repository at this point in the history

  4. Check for !current

    @firai
    firai authored Sep 3, 2023
    Configuration menu
    Copy the full SHA
    585b291 View commit details
    Browse the repository at this point in the history

  5. Add modifyEditor to signal connection

    @firai
    firai authored Sep 3, 2023
    Configuration menu
    Copy the full SHA
    5a5d9a4 View commit details
    Browse the repository at this point in the history

  6. Cast app.shell as ILabShell, then use currentChanged from that. From h… 

    …ttps://stackoverflow.com/questions/68120235/how-do-you-get-the-currently-active-notebook-name-in-jupyterlab .
    @firai
    firai authored Sep 3, 2023
    Configuration menu
    Copy the full SHA
    6b4246c View commit details
    Browse the repository at this point in the history

  7. Replace console.warn() with no-op comments

    @firai
    firai authored Sep 3, 2023
    Configuration menu
    Copy the full SHA
    79c4ae9 View commit details
    Browse the repository at this point in the history

  8. Lint

    @krassowski
    krassowski committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    b0ce3b5 View commit details
    Browse the repository at this point in the history

  9. Eslint

    @krassowski
    krassowski committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    74a92c1 View commit details
    Browse the repository at this point in the history