Add support for vim mode in Text Editor

[krassowski]

Relates to jupyterlab/jupyterlab#14599

Code changes

• Splits VimEditorManager out of VimCellManager
• Adds a file-editor specific shortcut to workaround escape being stolen by (hidden) search box in file editor

User facing changes

• Adds an option to enable vim in file editors too (on by default)
• Allows to close search box with escape when in normal vim mode; there are two sets of shortcuts one for 4.0 and one for 4.1 (which will include Automatically toggle search in selection jupyterlab/jupyterlab#14421)

[github-actions]

👈 Launch a Binder on branch krassowski/jupyterlab-vim/file-support

[github-actions]

👈 Launch a binder notebook on branch krassowski/jupyterlab-vim/file-support

[ianhi]

I'm finding that whenver I enter an editor I'm entering in insert mode, rather than normal mode (which is what we do for notebooks) is it easy to enter into normal mode for consistency?

[ianhi]

one other weird thing, it seems that modifyEditor gets called every time I hit Esc when in a fileeditor. Probably not optimal, but also doesn't seem to be a big deal

[krassowski]

one other weird thing, it seems that modifyEditor gets called every time I hit Esc when in a fileeditor. Probably not optimal, but also doesn't seem to be a big deal

This is because of the shortcut in schema bound to vim:enter-normal-mode which is a workaround for search box stealing Esc (in 4.0, once 4.1 is out we should be able to drop it). It should be innocent as the heavy operations in modifyEditor are guarded.

[krassowski]

I'm finding that whenver I enter an editor I'm entering in insert mode, rather than normal mode (which is what we do for notebooks) is it easy to enter into normal mode for consistency?

Resolved in bf589e5

[ianhi]

perfect! Thank you again! I think this would have taken me days of confusion to get something like this going.

[krassowski]

Thank you for super quick review and releases!