Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undo #92

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix undo #92

merged 2 commits into from
Jul 31, 2023

Conversation

krassowski
Copy link
Collaborator

Fixes #89

Builds on top of #90 but the changes could be backported standalone.

@github-actions
Copy link

Binder 👈 Launch a Binder on branch krassowski/jupyterlab-vim/fix-undo

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-vim/fix-undo

@krassowski krassowski added the bug Something isn't working label Jul 31, 2023
src/codemirrorCommands.ts Outdated Show resolved Hide resolved
@ianhi
Copy link
Collaborator

ianhi commented Jul 31, 2023

@krassowski ok for me to merge #90 first so we can have a nicer git history? As far as I can tell there aren't adidtional changes here correct?

@krassowski
Copy link
Collaborator Author

Yes #90 is ready from my point of view.

src/codemirrorCommands.ts Outdated Show resolved Hide resolved
@ianhi ianhi mentioned this pull request Jul 31, 2023
@ianhi
Copy link
Collaborator

ianhi commented Jul 31, 2023

@krassowski I suspect that this will need a rebase

Co-authored-by: Ian Hunt-Isaak <ianhuntisaak@gmail.com>
@ianhi ianhi merged commit 718d294 into jupyterlab-contrib:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undo with u does not work on jupyterlab 4
2 participants