Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Add wheel tests back on CI #431

Closed
jtpio opened this issue Apr 24, 2020 · 1 comment
Closed

Add wheel tests back on CI #431

jtpio opened this issue Apr 24, 2020 · 1 comment
Labels
testing
Milestone
Future

Comments

@jtpio
Copy link
Member

jtpio commented Apr 24, 2020

In #415 we removed the GitHub Actions workflow that installs the xeus-python wheel from PyPI.

This is because of the way kernel specs are installed in the jest tests (tmp folders). See this comment for more info: #415 (comment)

We should however add the workflow back on CI.
@jtpio jtpio added the testing label Apr 24, 2020
@jtpio jtpio added this to the Future milestone May 15, 2020
@jtpio jtpio mentioned this issue Jun 5, 2020
Merged
2 tasks
@jtpio
Copy link
Member Author

jtpio commented Sep 29, 2020

Closing as the tests are now using the xeus-python wheel in core lab:

https://github.com/jupyterlab/jupyterlab/blob/fa86276692e559525a1e3e8f407e1d17b2adaf97/scripts/ci_install.sh#L53-L56

@jtpio jtpio closed this as completed Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@jtpio