Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Switch to JupyterServer from @jupyterlab/testutils #462

Merged
merged 4 commits into from
Jun 5, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 4, 2020

Fixes #445.

Changes

  • Switch to JupyterServer from @jupyterlab/testutils, so there is no need for the run-test.py anymore and the deprecated JestApp (and tests become pure jest tests)
  • Match the folder and test structure in core lab more closely

@jtpio
Copy link
Member Author

jtpio commented Jun 4, 2020

The jest reporter now looks the same as in core lab too (since it's reusing the same settings):

jest-reporting

@jtpio
Copy link
Member Author

jtpio commented Jun 4, 2020

It looks like kernel specs (in particular the xpython spec) don't have to be installed manually anymore, most likely because the environment patching doesn't override the existing jupyter paths.

@jtpio
Copy link
Member Author

jtpio commented Jun 4, 2020

For the record, this is the output of running jupyter --paths (before running the tests) on the GitHub Actions runner from the conda workflow:

config:
    /home/runner/.jupyter
    /usr/share/miniconda/envs/jupyterlab-debugger/etc/jupyter
    /usr/local/etc/jupyter
    /etc/jupyter
data:
    /home/runner/.local/share/jupyter
    /usr/share/miniconda/envs/jupyterlab-debugger/share/jupyter
    /usr/local/share/jupyter
    /usr/share/jupyter
runtime:
    /home/runner/.local/share/jupyter/runtime

@jtpio jtpio force-pushed the tests-jupyter-server branch from 0d23292 to 63b8370 Compare June 4, 2020 14:16
@jtpio jtpio force-pushed the tests-jupyter-server branch from 33354d7 to 16acd32 Compare June 4, 2020 14:41
@jtpio jtpio added the testing label Jun 4, 2020
@jtpio
Copy link
Member Author

jtpio commented Jun 5, 2020

We should be able to add the wheel test back on CI after this: #431

@jtpio jtpio marked this pull request as ready for review June 5, 2020 09:51
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

👍

@afshin afshin merged commit ac07a78 into jupyterlab:master Jun 5, 2020
@jtpio jtpio added this to the 0.3.0 milestone Jun 8, 2020
@jtpio jtpio deleted the tests-jupyter-server branch July 8, 2020 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the tests to use JupyterServer from @jupyterlab/testutils
2 participants