-
-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
Great, I think this is a sufficient test case to work against on the kernel side. Could you please open an issue in https://github.com/jupyter-xeus/xeus-python/ and tag this issue there? Cheers, @KrzysztofSikoraCodete! |
Thanks @KrzysztofSikoraCodete for looking into this 👍 |
jupyter-xeus/xeus-python#246 should fix it. |
Thanks @JohanMabille! |
Awesome, thank you @JohanMabille! |
Just re-triggered the tests and it looks like the conda tests are now passing with the latest However the wheel is giving some errors: https://github.com/jupyterlab/debugger/pull/415/checks?check_run_id=612276325 |
See jupyter-xeus/xeus-python-wheel#54 for more context. The JupyterLab jest tests patch the jupyter paths here: https://github.com/jupyterlab/jupyterlab/blob/36a8da4d6bffea0fd9992a4d88627cffb46fe6a0/jupyterlab/tests/test_app.py#L88-L93 With the data directory becoming something like Which is why we install the Lines 15 to 25 in 247735d
|
As discussed, let's disable the wheel tests for now and re-enable them in a separate PR. |
Thanks! |
Thanks for merge! Nice to heard that. |
I've just added test for paging request. The test could pass If the filtered variables result were less than 2. Now we have more than 1 even though we use pagination.
I checked session configuration and supportsVariablePaging, has true.
Any suggestions?