add author_email #140
Merged
add author_email #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjagusch
commented
Feb 12, 2021
Comment on lines
+15
to
+18
| "author": { | ||
| "name": "{{ cookiecutter.author_name }}", | ||
| "email": "{{ cookiecutter.author_email }}" | ||
| }, |
There was a problem hiding this comment.
According to the package.json documentation, author is not a string but an object with up to three properties: name, email and url.
|
Tested locally: $ cookiecutter extension-cookiecutter-ts
author_name []: janjagusch
author_email []: jan.jagusch@gmail.com
python_name [myextension]:
labextension_name [myextension]:
project_short_description [A JupyterLab extension.]:
has_server_extension [n]:
has_binder [n]:
repository [https://github.com/github_username/myextension]:
$ cd myextension && python setup.py sdist bdist_wheel
running sdist
running jsdeps
running handle_files
running egg_info
writing myextension.egg-info/PKG-INFO
writing dependency_links to myextension.egg-info/dependency_links.txt
writing requirements to myextension.egg-info/requires.txt
writing top-level names to myextension.egg-info/top_level.txt
reading manifest file 'myextension.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching 'jupyter-config/myextension.json'
no previously-included directories found matching '**/node_modules'
no previously-included directories found matching 'lib'
warning: no previously-included files matching '*~' found anywhere in distribution
warning: no previously-included files matching '*.pyc' found anywhere in distribution
warning: no previously-included files matching '*.pyo' found anywhere in distribution
warning: no previously-included files matching '.git' found anywhere in distribution
warning: no previously-included files matching '.ipynb_checkpoints' found anywhere in distribution
writing manifest file 'myextension.egg-info/SOURCES.txt'
running check
creating myextension-0.1.0
creating myextension-0.1.0/myextension
creating myextension-0.1.0/myextension.egg-info
creating myextension-0.1.0/myextension/labextension
creating myextension-0.1.0/myextension/labextension/static
creating myextension-0.1.0/src
creating myextension-0.1.0/style
copying files to myextension-0.1.0...
copying LICENSE -> myextension-0.1.0
copying MANIFEST.in -> myextension-0.1.0
copying README.md -> myextension-0.1.0
copying install.json -> myextension-0.1.0
copying package.json -> myextension-0.1.0
copying pyproject.toml -> myextension-0.1.0
copying setup.py -> myextension-0.1.0
copying tsconfig.json -> myextension-0.1.0
copying yarn.lock -> myextension-0.1.0
copying myextension/__init__.py -> myextension-0.1.0/myextension
copying myextension/_version.py -> myextension-0.1.0/myextension
copying myextension.egg-info/PKG-INFO -> myextension-0.1.0/myextension.egg-info
copying myextension.egg-info/SOURCES.txt -> myextension-0.1.0/myextension.egg-info
copying myextension.egg-info/dependency_links.txt -> myextension-0.1.0/myextension.egg-info
copying myextension.egg-info/not-zip-safe -> myextension-0.1.0/myextension.egg-info
copying myextension.egg-info/requires.txt -> myextension-0.1.0/myextension.egg-info
copying myextension.egg-info/top_level.txt -> myextension-0.1.0/myextension.egg-info
copying myextension/labextension/package.json -> myextension-0.1.0/myextension/labextension
copying myextension/labextension/static/534.10842b3b8a1d0dc1c841.js -> myextension-0.1.0/myextension/labextension/static
copying myextension/labextension/static/568.61a94b65be4701f2c796.js -> myextension-0.1.0/myextension/labextension/static
copying myextension/labextension/static/remoteEntry.7ce1fa46ace37fb789b5.js -> myextension-0.1.0/myextension/labextension/static
copying myextension/labextension/static/style.js -> myextension-0.1.0/myextension/labextension/static
copying src/index.ts -> myextension-0.1.0/src
copying style/base.css -> myextension-0.1.0/style
copying style/index.css -> myextension-0.1.0/style
copying style/index.js -> myextension-0.1.0/style
Writing myextension-0.1.0/setup.cfg
Creating tar archive
removing 'myextension-0.1.0' (and everything under it)
running bdist_wheel
running build
running build_py
installing to build/bdist.macosx-10.9-x86_64/wheel
running install
running install_lib
creating build/bdist.macosx-10.9-x86_64/wheel
creating build/bdist.macosx-10.9-x86_64/wheel/myextension
copying build/lib/myextension/_version.py -> build/bdist.macosx-10.9-x86_64/wheel/myextension
copying build/lib/myextension/__init__.py -> build/bdist.macosx-10.9-x86_64/wheel/myextension
creating build/bdist.macosx-10.9-x86_64/wheel/myextension/labextension
copying build/lib/myextension/labextension/package.json -> build/bdist.macosx-10.9-x86_64/wheel/myextension/labextension
creating build/bdist.macosx-10.9-x86_64/wheel/myextension/labextension/static
copying build/lib/myextension/labextension/static/style.js -> build/bdist.macosx-10.9-x86_64/wheel/myextension/labextension/static
copying build/lib/myextension/labextension/static/568.61a94b65be4701f2c796.js -> build/bdist.macosx-10.9-x86_64/wheel/myextension/labextension/static
copying build/lib/myextension/labextension/static/remoteEntry.7ce1fa46ace37fb789b5.js -> build/bdist.macosx-10.9-x86_64/wheel/myextension/labextension/static
copying build/lib/myextension/labextension/static/534.10842b3b8a1d0dc1c841.js -> build/bdist.macosx-10.9-x86_64/wheel/myextension/labextension/static
running install_data
creating build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data
creating build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data
creating build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data/share
creating build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data/share/jupyter
creating build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data/share/jupyter/labextensions
creating build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data/share/jupyter/labextensions/myextension
copying myextension/labextension/package.json -> build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data/share/jupyter/labextensions/myextension
copying install.json -> build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data/share/jupyter/labextensions/myextension
creating build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data/share/jupyter/labextensions/myextension/static
copying myextension/labextension/static/568.61a94b65be4701f2c796.js -> build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data/share/jupyter/labextensions/myextension/static
copying myextension/labextension/static/style.js -> build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data/share/jupyter/labextensions/myextension/static
copying myextension/labextension/static/534.10842b3b8a1d0dc1c841.js -> build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data/share/jupyter/labextensions/myextension/static
copying myextension/labextension/static/remoteEntry.7ce1fa46ace37fb789b5.js -> build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.data/data/share/jupyter/labextensions/myextension/static
running install_egg_info
Copying myextension.egg-info to build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0-py3.9.egg-info
running install_scripts
adding license file "LICENSE" (matched pattern "LICEN[CS]E*")
creating build/bdist.macosx-10.9-x86_64/wheel/myextension-0.1.0.dist-info/WHEEL
creating 'dist/myextension-0.1.0-py3-none-any.whl' and adding 'build/bdist.macosx-10.9-x86_64/wheel' to it
adding 'myextension/__init__.py'
adding 'myextension/_version.py'
adding 'myextension/labextension/package.json'
adding 'myextension/labextension/static/534.10842b3b8a1d0dc1c841.js'
adding 'myextension/labextension/static/568.61a94b65be4701f2c796.js'
adding 'myextension/labextension/static/remoteEntry.7ce1fa46ace37fb789b5.js'
adding 'myextension/labextension/static/style.js'
adding 'myextension-0.1.0.data/data/share/jupyter/labextensions/myextension/install.json'
adding 'myextension-0.1.0.data/data/share/jupyter/labextensions/myextension/package.json'
adding 'myextension-0.1.0.data/data/share/jupyter/labextensions/myextension/static/534.10842b3b8a1d0dc1c841.js'
adding 'myextension-0.1.0.data/data/share/jupyter/labextensions/myextension/static/568.61a94b65be4701f2c796.js'
adding 'myextension-0.1.0.data/data/share/jupyter/labextensions/myextension/static/remoteEntry.7ce1fa46ace37fb789b5.js'
adding 'myextension-0.1.0.data/data/share/jupyter/labextensions/myextension/static/style.js'
adding 'myextension-0.1.0.dist-info/LICENSE'
adding 'myextension-0.1.0.dist-info/METADATA'
adding 'myextension-0.1.0.dist-info/WHEEL'
adding 'myextension-0.1.0.dist-info/top_level.txt'
adding 'myextension-0.1.0.dist-info/RECORD'
removing build/bdist.macosx-10.9-x86_64/wheel |
janjagusch
added a commit
to janjagusch/jupyterlab
that referenced
this pull request
Feb 12, 2021
We have just added "author_name" to the cookiecutter template. Would be nice to reflect the changes here. :) More information: jupyterlab/extension-cookiecutter-ts#140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139