Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add author_email #140

Merged
merged 4 commits into from
Feb 12, 2021
Merged

add author_email #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2be3c4c
add author_email
janjagusch Feb 12, 2021
313b391
convert author to object
janjagusch Feb 12, 2021
c903651
use nested author.email
janjagusch Feb 12, 2021
d78b2c3
revert to original formatting
janjagusch Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cookiecutter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"author_name": "",
"author_email": "",
"python_name": "myextension",
"labextension_name": "{{ cookiecutter.python_name }}",
"project_short_description": "A JupyterLab extension.",
Expand Down
5 changes: 4 additions & 1 deletion {{cookiecutter.python_name}}/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
"url": "{{ cookiecutter.repository }}/issues"
},
"license": "BSD-3-Clause",
"author": "{{ cookiecutter.author_name }}",
"author": {
"name": "{{ cookiecutter.author_name }}",
"email": "{{ cookiecutter.author_email }}"
},
Comment on lines +15 to +18
Copy link
Contributor Author

@janjagusch janjagusch Feb 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the package.json documentation, author is not a string but an object with up to three properties: name, email and url.

"files": [
"lib/**/*.{d.ts,eot,gif,html,jpg,js,js.map,json,png,svg,woff2,ttf}",
"style/**/*.{css,.js,eot,gif,html,jpg,json,png,svg,woff2,ttf}"
Expand Down
3 changes: 2 additions & 1 deletion {{cookiecutter.python_name}}/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@
name=name,
version=pkg_json["version"],
url=pkg_json["homepage"],
author=pkg_json["author"],
author=pkg_json["author"]["name"],
author_email=pkg_json["author"]["email"],
description=pkg_json["description"],
license=pkg_json["license"],
long_description=long_description,
Expand Down