-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/export added #658
/export added #658
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! The original issue was authored a while ago. I need to check with the dev team on whether this is still a feature we want to include in the latest release, and if so, what remaining work needs to be done before this can be merged.
We appreciate your patience as we reach a decision. 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spoke to the team, and yes, this is a feature we would like to include in Jupyter AI. Thank you for working on this!
However, I do have one point of feedback that needs to be addressed before it is merged. @srdas can help with addressing this so we can merge your PR more quickly. 🤗
for more information, see https://pre-commit.ci
- Added multiple chat history files - changed export to mention markdown files only - respond with filename in chat
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srdas One last change, and this is good to go. Awesome work!
Using Markdown formatting when displaying file paths
Slack note to merge from dlqqq approving the change made
@meeseeksdev please backport to 1.x |
Co-authored-by: Apurva Khatri <apurvakhatri2011@gmail.com>
* export chat to markdown functionality added * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update export.py - Added multiple chat history files - changed export to mention markdown files only - respond with filename in chat * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Edits to /export function Using Markdown formatting when displaying file paths --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sanjiv Das <srdas@scu.edu>
* export chat to markdown functionality added * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update export.py - Added multiple chat history files - changed export to mention markdown files only - respond with filename in chat * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Edits to /export function Using Markdown formatting when displaying file paths --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sanjiv Das <srdas@scu.edu>
Hello Team,
Issue number of the reported bug or feature request: #460
Changes
I have added a new chat handler, whose primary task is to export the chat in a markdown format. The markdown file is saved under playground directory.
Testing performed
The functionality has been tested on my system (MacOS).
Additional context
The functionality is working fine. This is my first PR in the repository, so, kindly let me know, if any upgrades are needed.