Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/export added #658

Merged
merged 5 commits into from
Mar 18, 2024
Merged

/export added #658

merged 5 commits into from
Mar 18, 2024

Conversation

apurvakhatri
Copy link
Contributor

Hello Team,

Issue number of the reported bug or feature request: #460

Changes
I have added a new chat handler, whose primary task is to export the chat in a markdown format. The markdown file is saved under playground directory.

Testing performed
The functionality has been tested on my system (MacOS).

Additional context
The functionality is working fine. This is my first PR in the repository, so, kindly let me know, if any upgrades are needed.

Copy link

welcome bot commented Feb 27, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! The original issue was authored a while ago. I need to check with the dev team on whether this is still a feature we want to include in the latest release, and if so, what remaining work needs to be done before this can be merged.

We appreciate your patience as we reach a decision. 🤗

@dlqqq dlqqq added the enhancement New feature or request label Mar 5, 2024
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke to the team, and yes, this is a feature we would like to include in Jupyter AI. Thank you for working on this!

However, I do have one point of feedback that needs to be addressed before it is merged. @srdas can help with addressing this so we can merge your PR more quickly. 🤗

packages/jupyter-ai/jupyter_ai/chat_handlers/export.py Outdated Show resolved Hide resolved
apurvakhatri and others added 4 commits March 16, 2024 00:29
- Added multiple chat history files
- changed export to mention markdown files only
- respond with filename in chat
dlqqq
dlqqq previously requested changes Mar 18, 2024
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srdas One last change, and this is good to go. Awesome work!

packages/jupyter-ai/jupyter_ai/chat_handlers/export.py Outdated Show resolved Hide resolved
Using Markdown formatting when displaying file paths
@srdas srdas dismissed dlqqq’s stale review March 18, 2024 21:05

Slack note to merge from dlqqq approving the change made

@srdas srdas merged commit 4814904 into jupyterlab:main Mar 18, 2024
8 checks passed
@srdas
Copy link
Collaborator

srdas commented Mar 18, 2024

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter-ai that referenced this pull request Mar 18, 2024
srdas pushed a commit that referenced this pull request Mar 18, 2024
Co-authored-by: Apurva Khatri <apurvakhatri2011@gmail.com>
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
* export chat to markdown functionality added

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update export.py

- Added multiple chat history files
- changed export to mention markdown files only
- respond with filename in chat

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Edits to /export function

Using Markdown formatting when displaying file paths

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sanjiv Das <srdas@scu.edu>
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* export chat to markdown functionality added

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update export.py

- Added multiple chat history files
- changed export to mention markdown files only
- respond with filename in chat

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Edits to /export function

Using Markdown formatting when displaying file paths

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sanjiv Das <srdas@scu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants