Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): fix user login in routing cypress framework #5950

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Sep 18, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR fixes user logins in routing Cypress framework.
In addition to that, we now also handle a rare case where the spec name will be a single word (__all) that resulted in Cypress to stop working.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Its been quite a while since the user login flow was changed and went unhandled in Cypress and no one was bothered to fix given that other tasks were given the priority.

How did you test it?

image

As a matter of fact, this PR does not fix the hooks issue that exist in volume and rule based routing.

Checklist

  • I formatted the code prettier . --write
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 18, 2024
@pixincreate pixincreate added this to the September 2024 Release milestone Sep 18, 2024
@pixincreate pixincreate self-assigned this Sep 18, 2024
@pixincreate pixincreate requested a review from a team as a code owner September 18, 2024 18:27
Copy link

semanticdiff-com bot commented Sep 18, 2024

Review changes with SemanticDiff.

Analyzed 8 of 8 files.

Overall, the semantic diff is 11% smaller than the GitHub diff.

1 files do not contain logic changes.

Filename Status
✔️ cypress-tests/cypress/support/commands.js 8.17% smaller
✔️ cypress-tests/cypress/e2e/RoutingTest/00000-PriorityRouting.cy.js 10.58% smaller
✔️ cypress-tests/cypress/e2e/RoutingTest/00001-VolumeBasedRouting.cy.js 9.82% smaller
✔️ cypress-tests/cypress/e2e/RoutingTest/00002-RuleBasedRouting.cy.js 11.46% smaller
✔️ cypress-tests/cypress/e2e/RoutingTest/00003-Retries.cy.js Analyzed
✔️ cypress-tests/cypress/e2e/PayoutUtils/Commons.js Analyzed
✔️ cypress-tests/cypress/e2e/PaymentUtils/Commons.js 41.35% smaller
✔️ cypress-tests/cypress/e2e/PaymentUtils/Novalnet.js No logic changes found

@pixincreate pixincreate changed the title fix(cypress): fix user login in routing cypress framwork fix(cypress): fix user login in routing cypress framework Sep 18, 2024
@pixincreate pixincreate marked this pull request as draft September 18, 2024 18:43
@pixincreate pixincreate marked this pull request as ready for review September 19, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants