feat(connector): [DataTrans] ADD 3DS Flow #6026

awasthi21 · 2024-09-25T11:12:28Z

Type of Change

Description

Added 3DS Flow

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Three 3ds

**Request**
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_iClV9gEjhQBYt3sTzwjloL1IGSd6VpSC2JR0BBJ9gbrFEo6eHkfD5SSJudjoHlzq' \
--data-raw '{
    "amount": 1500,
    "currency": "USD",
    "amount_to_capture": 1500,
    "confirm": true,
    "capture_method": "automatic",
    "authentication_type": "three_ds",
    "payment_method": "card",
    "payment_method_type": "credit",
      "email": "guest@example.com",
    "payment_method_data": {
        "card": {
            "card_number": "4111111111111111",
            "card_exp_month": "06",
            "card_exp_year": "25",
            "card_holder_name": "joseph Doe",
            "card_cvc": "123"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "Zurich",
            "state": "asd",
            "zip": "8008",
            "country": "CH",
            "first_name": "joseph",
            "last_name": "Doe"
        }
    }
}'
**Response:**

{
    "payment_id": "pay_vHjy5fKzjHZxKtxI098X",
    "merchant_id": "postman_merchant_GHAction_89a6aa6f-012b-407e-9a8c-34ca16816f21",
    "status": "requires_customer_action",
    "amount": 1500,
    "net_amount": 1500,
    "amount_capturable": 1500,
    "amount_received": null,
    "connector": "datatrans",
    "client_secret": "pay_vHjy5fKzjHZxKtxI098X_secret_u75qIY4GA4cpgHEVxe9J",
    "created": "2024-09-25T11:27:14.567Z",
    "currency": "USD",
    "customer_id": null,
    "customer": {
        "id": null,
        "name": null,
        "email": "guest@example.com",
        "phone": null,
        "phone_country_code": null
    },
    "description": null,
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "1111",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "411111",
            "card_extended_bin": null,
            "card_exp_month": "06",
            "card_exp_year": "25",
            "card_holder_name": null,
            "payment_checks": null,
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": null,
    "billing": {
        "address": {
            "city": "Zurich",
            "country": "CH",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "8008",
            "state": "asd",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": null,
        "email": null
    },
    "order_details": null,
    "email": null,
    "name": null,
    "phone": null,
    "return_url": null,
    "authentication_type": "three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": {
        "type": "redirect_to_url",
        "redirect_to_url": "http://localhost:8080/payments/redirect/pay_vHjy5fKzjHZxKtxI098X/postman_merchant_GHAction_89a6aa6f-012b-407e-9a8c-34ca16816f21/pay_vHjy5fKzjHZxKtxI098X_1"
    },
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": null,
    "connector_transaction_id": "240925132715468655",
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": null,
    "payment_link": null,
    "profile_id": "pro_42yrBwduYyd6qykBOXCS",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_KFw9ms4pVBoP3ovswSEu",
    "incremental_authorization_allowed": false,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-09-25T11:42:14.567Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-09-25T11:27:15.520Z",
    "charges": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null
}
**Redirect Response :**
{
    "payment_id": "pay_vHjy5fKzjHZxKtxI098X",
    "merchant_id": "postman_merchant_GHAction_89a6aa6f-012b-407e-9a8c-34ca16816f21",
    "status": "succeeded",
    "amount": 1500,
    "net_amount": 1500,
    "amount_capturable": 0,
    "amount_received": 1500,
    "connector": "datatrans",
    "client_secret": "pay_vHjy5fKzjHZxKtxI098X_secret_u75qIY4GA4cpgHEVxe9J",
    "created": "2024-09-25T11:27:14.567Z",
    "currency": "USD",
    "customer_id": null,
    "customer": {
        "id": null,
        "name": null,
        "email": "guest@example.com",
        "phone": null,
        "phone_country_code": null
    },
    "description": null,
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "automatic",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "1111",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "411111",
            "card_extended_bin": null,
            "card_exp_month": "06",
            "card_exp_year": "25",
            "card_holder_name": null,
            "payment_checks": null,
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": null,
    "billing": {
        "address": {
            "city": "Zurich",
            "country": "CH",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "8008",
            "state": "asd",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": null,
        "email": null
    },
    "order_details": null,
    "email": null,
    "name": null,
    "phone": null,
    "return_url": null,
    "authentication_type": "three_ds",
    "statement_descriptor_name": null,
    "statement_descriptor_suffix": null,
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": "240925132715468655",
    "frm_message": null,
    "metadata": null,
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": null,
    "payment_link": null,
    "profile_id": "pro_42yrBwduYyd6qykBOXCS",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_KFw9ms4pVBoP3ovswSEu",
    "incremental_authorization_allowed": false,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-09-25T11:42:14.567Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-09-25T11:28:51.196Z",
    "charges": null,
    "frm_metadata": null,
    "merchant_order_reference_id": null,
    "order_tax_amount": null,
    "connector_mandate_id": null
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2024-09-25T11:12:31Z

Review changes with

Changed Files

File	Status
crates/hyperswitch_connectors/src/connectors/paybox/transformers.rs	63% smaller
crates/hyperswitch_connectors/src/connectors/datatrans.rs	60% smaller
crates/hyperswitch_connectors/src/connectors/datatrans/transformers.rs	4% smaller
config/config.example.toml	Unsupported file format
config/deployments/integration_test.toml	Unsupported file format
config/deployments/production.toml	Unsupported file format
config/deployments/sandbox.toml	Unsupported file format
config/development.toml	Unsupported file format
config/docker_compose.toml	Unsupported file format
crates/hyperswitch_connectors/src/utils.rs	0% smaller
crates/hyperswitch_interfaces/src/configs.rs	0% smaller
crates/router/src/configs/defaults/payment_connector_required_fields.rs	0% smaller
loadtest/config/development.toml	Unsupported file format

deepanshu-iiitu · 2024-09-26T09:36:06Z

crates/router/src/connector/datatrans/transformers.rs

+pub struct CardHolder {
+    cardholder_name: Secret<String>,
+    email: Email,
+    bill_addr_line1: Secret<String>,
+    bill_addr_post_code: Secret<String>,
+    bill_addr_city: String,
+    bill_addr_state: Secret<String>,
+    bill_addr_country: common_enums::CountryAlpha2,


Make only required fields as mandatory and add the in crates/router/src/configs/defaults.rs.
Make strongly recommended fields as optional and add a comment highlighting those fields.

deepanshu-iiitu · 2024-09-26T09:43:03Z

crates/router/src/connector/datatrans/transformers.rs

+                    incremental_authorization_allowed: Some(
+                        status == enums::AttemptStatus::Authorized,
+                    ),


This will always be false hence no need to pass it here.

deepanshu-iiitu · 2024-09-26T09:51:50Z

crates/router/src/connector/datatrans.rs

        connectors: &settings::Connectors,
    ) -> CustomResult<String, errors::ConnectorError> {
        let base_url = self.base_url(connectors);
-        Ok(format!("{base_url}v1/transactions/authorize"))
+        if req.is_three_ds() {


Please test PSYNC, Capture, Refunds and Incremental Auth for 3DS transactions.

tested ,
For incremental Auth we have a different merchant account. Not able to test 3ds + incremental Auth
Except that everything is working

SanchithHegde · 2024-09-27T08:24:53Z

crates/router/src/connector/datatrans/transformers.rs

+const REDIRECTION_SBX_URL: &str = "https://pay.sandbox.datatrans.com";
+const REDIRECTION_PROD_URL: &str = "https://pay.datatrans.com";


Why have we hardcoded these URLs?

This URL is used in the 3DS redirection

fn handle_response( &self, data: &types::PaymentsAuthorizeRouterData, event_builder: Option<&mut ConnectorEvent>, res: Response, ) -> CustomResult<types::PaymentsAuthorizeRouterData, errors::ConnectorError> { let response: datatrans::DatatransResponse = res .response .parse_struct("Datatrans PaymentsAuthorizeResponse") .change_context(errors::ConnectorError::ResponseDeserializationFailed)?; event_builder.map(|i| i.set_response_body(&response)); router_env::logger::info!(connector_response=?response); types::RouterData::try_from(types::ResponseRouterData { response, data: data.clone(), http_code: res.status_code, }) }

in handle response there's no other way to retrieve the base/secondary_url ( connectors: &settings::Connectors, not there in handle_response) ,Had to hard code it

sai-harsha-vardhan · 2024-09-30T06:32:09Z

crates/hyperswitch_domain_models/src/router_request_types.rs

@@ -129,6 +129,8 @@ pub struct PaymentsIncrementalAuthorizationData {
    pub currency: storage_enums::Currency,
    pub reason: Option<String>,
    pub connector_transaction_id: String,
+    pub minor_additional_amount: MinorUnit,


I think, instead of adding new minor fields here, we should refactor the existing fields as minor unit

…ced-payment-flows

deepanshu-iiitu · 2025-02-06T08:09:24Z

crates/hyperswitch_connectors/src/connectors/datatrans.rs

+            router_env::logger::info!(connector_response=?response);
+            Ok(ErrorResponse {
+                status_code: res.status_code,
+                code: response.clone(),


Can we make this NO_ERROR_CODE

config/config.example.toml

crates/hyperswitch_connectors/src/connectors/datatrans.rs

crates/hyperswitch_connectors/src/connectors/datatrans/transformers.rs

crates/router/src/configs/defaults/payment_connector_required_fields.rs

…ced-payment-flows

…unt-configurable * 'main' of github.com:juspay/hyperswitch: (37 commits) refactor(router): add display_name field to connector feature api (#7121) ci(cypress): Add Tests for Customer Deletion and Psync flows (#7158) feat(connector): [DataTrans] ADD 3DS Flow (#6026) chore(version): 2025.02.07.0 chore(connectors): [fiuu] update pm_filters for apple pay and google pay (#7182) feat(router): add `organization_id` in authentication table and add it in authentication events (#7168) fix(dashboard_metadata): mask `poc_email` and `data_value` for DashboardMetadata (#7130) feat(core): Add support for v2 payments get intent using merchant reference id (#7123) refactor(customer): return redacted customer instead of error (#7122) fix(connector): handle unexpected error response from bluesnap connector (#7120) feat(routing): Contract based routing integration (#6761) refactor(dynamic_fields): dynamic fields for Adyen and Stripe, renaming klarnaCheckout, WASM for KlarnaCheckout (#7015) feat(connector): [COINGATE] Add Template PR (#7052) chore(roles): remove redundant variant from PermissionGroup (#6985) refactor(router): store `network_transaction_id` for `off_session` payments irrespective of the `is_connector_agnostic_mit_enabled` config (#7083) chore(connector): [Fiuu] log keys in the PSync response (#7189) ci(cypress): fix nmi and paypal (#7173) chore(version): 2025.02.06.0 chore(postman): update Postman collection files feat(connector): [Deutschebank] Add Access Token Error struct (#7127) ...

awasthi21 added the A-connector-integration Area: Connector integration label Sep 25, 2024

awasthi21 self-assigned this Sep 25, 2024

awasthi21 requested review from a team as code owners September 25, 2024 11:12

awasthi21 force-pushed the 6211-featconnector-datatrans-implement-advanced-payment-flows branch from ce511fb to 35b85d5 Compare September 25, 2024 11:25

awasthi21 linked an issue Sep 26, 2024 that may be closed by this pull request

feat(connector): [DATATRANS] add Connector Payment Flows Code #5027

Closed

awasthi21 removed a link to an issue Sep 26, 2024

feat(connector): [DATATRANS] add Connector Payment Flows Code #5027

Closed

deepanshu-iiitu requested changes Sep 26, 2024

View reviewed changes

awasthi21 force-pushed the 6211-featconnector-datatrans-implement-advanced-payment-flows branch 2 times, most recently from 4303fba to 7c59b17 Compare September 26, 2024 13:03

awasthi21 requested a review from deepanshu-iiitu September 26, 2024 13:11

deepanshu-iiitu previously approved these changes Sep 26, 2024

View reviewed changes

SanchithHegde reviewed Sep 27, 2024

View reviewed changes

sai-harsha-vardhan reviewed Sep 30, 2024

View reviewed changes

awasthi21 dismissed deepanshu-iiitu’s stale review via 9522536 February 3, 2025 09:16

awasthi21 force-pushed the 6211-featconnector-datatrans-implement-advanced-payment-flows branch from 7c59b17 to 9522536 Compare February 3, 2025 09:16

3ds-fix

d9d162e

awasthi21 force-pushed the 6211-featconnector-datatrans-implement-advanced-payment-flows branch from 8c2c8d2 to d9d162e Compare February 5, 2025 12:18

awasthi21 changed the title ~~feat(connector): [DataTrans] ADD 3DS and Incremental Auth~~ feat(connector): [DataTrans] ADD 3DS Flow Feb 5, 2025

awasthi21 and others added 4 commits February 5, 2025 17:56

3ds-fix

3d7cc78

config-update

0099af4

fix/error-handling

d26819a

Merge branch 'main' into 6211-featconnector-datatrans-implement-advan…

905359a

…ced-payment-flows

deepanshu-iiitu requested changes Feb 6, 2025

View reviewed changes

fix/error-handling

dbf7fb7

awasthi21 requested review from sai-harsha-vardhan and SanchithHegde February 6, 2025 08:41

awasthi21 requested a review from deepanshu-iiitu February 6, 2025 08:41

deepanshu-iiitu previously approved these changes Feb 6, 2025

View reviewed changes

hyperswitch-bot bot dismissed deepanshu-iiitu’s stale review via 7826e2c February 6, 2025 08:58

deepanshu-iiitu previously approved these changes Feb 6, 2025

View reviewed changes

awasthi21 requested a review from jagan-jaya February 6, 2025 09:31

fix/error-handling

6a846de

awasthi21 dismissed deepanshu-iiitu’s stale review via 6a846de February 6, 2025 09:57

awasthi21 force-pushed the 6211-featconnector-datatrans-implement-advanced-payment-flows branch from 7826e2c to 6a846de Compare February 6, 2025 09:57

deepanshu-iiitu self-requested a review February 6, 2025 11:36

deepanshu-iiitu previously approved these changes Feb 6, 2025

View reviewed changes

jagan-jaya reviewed Feb 6, 2025

View reviewed changes

fix/error-handling

d1fbbb3

awasthi21 dismissed deepanshu-iiitu’s stale review via d1fbbb3 February 6, 2025 12:37

awasthi21 force-pushed the 6211-featconnector-datatrans-implement-advanced-payment-flows branch from 4ec716d to d1fbbb3 Compare February 6, 2025 12:37

awasthi21 requested a review from deepanshu-iiitu February 6, 2025 12:39

chore: run formatter

647b0ec

jagan-jaya approved these changes Feb 6, 2025

View reviewed changes

Merge branch 'main' into 6211-featconnector-datatrans-implement-advan…

8dfc8e2

…ced-payment-flows

awasthi21 removed request for SanchithHegde and sai-harsha-vardhan February 6, 2025 17:05

deepanshu-iiitu approved these changes Feb 6, 2025

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Feb 7, 2025

Merged via the queue into main with commit 4693d21 Feb 7, 2025
17 of 20 checks passed

Gnanasundari24 deleted the 6211-featconnector-datatrans-implement-advanced-payment-flows branch February 7, 2025 05:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [DataTrans] ADD 3DS Flow #6026

feat(connector): [DataTrans] ADD 3DS Flow #6026

awasthi21 commented Sep 25, 2024 •

edited

Loading

semanticdiff-com bot commented Sep 25, 2024 •

edited

Loading

deepanshu-iiitu Sep 26, 2024

awasthi21 Sep 26, 2024

deepanshu-iiitu Sep 26, 2024

awasthi21 Sep 26, 2024

deepanshu-iiitu Sep 26, 2024

awasthi21 Sep 26, 2024

SanchithHegde Sep 27, 2024

awasthi21 Sep 27, 2024 •

edited

Loading

sai-harsha-vardhan Sep 30, 2024

awasthi21 Feb 5, 2025

deepanshu-iiitu Feb 6, 2025

awasthi21 Feb 6, 2025

		const REDIRECTION_SBX_URL: &str = "https://pay.sandbox.datatrans.com";
		const REDIRECTION_PROD_URL: &str = "https://pay.datatrans.com";

feat(connector): [DataTrans] ADD 3DS Flow #6026

feat(connector): [DataTrans] ADD 3DS Flow #6026

Conversation

awasthi21 commented Sep 25, 2024 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

semanticdiff-com bot commented Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awasthi21 Sep 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awasthi21 commented Sep 25, 2024 •

edited

Loading

semanticdiff-com bot commented Sep 25, 2024 •

edited

Loading

awasthi21 Sep 27, 2024 •

edited

Loading