Ci(Cypress): Add PML test and Dynamic Fields Test for Novalnet #6544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files |
cookieg13
force-pushed
the
addPMLTestForNovalnet
branch
from
2082bb0 to
e9a3720
Compare
cookieg13
changed the title
cookieg13
force-pushed
the
addPMLTestForNovalnet
branch
from
e9a3720 to
a414b1d
Compare
cookieg13
force-pushed
the
addPMLTestForNovalnet
branch
from
a414b1d to
1011c8e
Compare
pixincreate
added
the
S-needs-conflict-resolution
|
hey, can you resolve the conflicts? |
|
Hey @cookieg13 |
cookieg13
force-pushed
the
addPMLTestForNovalnet
branch
2 times, most recently
from
b83fdbe to
35b661b
Compare
|
|
||
| // creating payment with currency as USD and no billing email | ||
| // billing.email is mandatory for novalnet | ||
| it("create-payment-call-test", () => { |
There was a problem hiding this comment.
Haven't you added positive test case for novalnet?
Because I can see test case for stripe only
There was a problem hiding this comment.
hey @likhinbopanna I now added one positive case for Novalnet, and one positive case for stripe. Would that be sufficient?
pixincreate
reviewed
Jan 3, 2025
cypress-tests/cypress/e2e/PaymentMethodListTest/00000-PaymentMethodListTests.cy.js
Show resolved
Hide resolved
cypress-tests/cypress/e2e/PaymentMethodListTest/00000-PaymentMethodListTests.cy.js
Outdated
Show resolved
Hide resolved
| fixtures.createConnectorBody, | ||
| cardCreditEnabledInEur, | ||
| globalState, | ||
| "novalnet", |
There was a problem hiding this comment.
are the api keys updated in the creds file? if not, pml tests are bound to fail.
There was a problem hiding this comment.
Sure checking! I assumed you meant the local creds.json
cypress-tests/cypress/e2e/PaymentMethodListTest/00000-PaymentMethodListTests.cy.js
Show resolved
Hide resolved
| // payment method list should only have credit with stripe | ||
| it("payment-method-list-call-test", () => { | ||
| const data = | ||
| getConnectorDetails("stripe")["pm_list"]["PmListResponse"][ |
There was a problem hiding this comment.
if not asking too much, do you mind renaming the Stripe.js file to Connector.js since it is more meaningful and common across all the connectors from my unerstanding?
pixincreate
added
S-waiting-on-review
cookieg13
force-pushed
the
addPMLTestForNovalnet
branch
from
916cfd2 to
55741f7
Compare
likhinbopanna
previously approved these changes
Jan 3, 2025
cookieg13
force-pushed
the
addPMLTestForNovalnet
branch
from
145dd3c to
1fb8c40
Compare
pixincreate
approved these changes
Jan 3, 2025
likhinbopanna
approved these changes
Jan 3, 2025
cookieg13
changed the title
pixincreate
added a commit
to Ankesh2004/hyperswitch
that referenced
this pull request
Jan 9, 2025
…r-verifyurl-in-redirection-handler * 'main' of github.com:juspay/hyperswitch: (30 commits) test(cypress): add test for In Memory Cache (juspay#6961) chore(version): 2025.01.09.1 fix(dummyconnector): add tenant id in dummyconnector requests (juspay#7008) chore(version): 2025.01.09.0 fix(cypress): backup and restore sessions when using user apis (juspay#6978) feat(users): handle edge features for users in tenancy (juspay#6990) chore(dynamic-fields): [Worldpay] update dynamic fields for payments (juspay#7002) chore(version): 2025.01.08.0 fix: consider status of payment method before filtering wallets in list pm (juspay#7004) feat(core): add columns unified error code and error message in refund table (juspay#6933) feat(connector): [Fiuu] Consume transaction id for error cases for Fiuu (juspay#6998) docs(cypress): update cypress documentation (juspay#6956) chore(version): 2025.01.07.0 chore(keymanager): add tenant-id to keymanager requests (juspay#6968) ci(cypress): Add Session Token Testcases (juspay#6683) Ci(Cypress): Add PML test and Dynamic Fields Test for Novalnet (juspay#6544) chore(version): 2025.01.06.0 ci(cypress): fix adyen sofort in cypress (juspay#6984) chore: add migrations for Currency type in DB (juspay#6980) chore(version): 2025.01.03.0 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added PML test for Novalnet
Additional Changes
Motivation and Context
#6463 (comment)
How did you test it?
Ran Cypress Test locally:
PaymentMethodListTests
DynamicFields
Checklist
cargo +nightly fmt --allcargo clippy