-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resources and granular permission groups for reconciliation #6591
base: main
Are you sure you want to change the base?
Conversation
Changed Files
|
bf242e7
to
e49751b
Compare
e49751b
to
2ea3f1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the new group and Recon parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core part LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know once you get approvals from PMs regarding recon groups in roles. I'll approve.
Other than that, LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kashif-m, can you add view variants as well where we added manage groups in roles. This will maintain consistency with other roles.
crates/router/src/services/authorization/roles/predefined_roles.rs
Outdated
Show resolved
Hide resolved
crates/router/src/services/authorization/roles/predefined_roles.rs
Outdated
Show resolved
Hide resolved
6e07d9a
to
caacbcb
Compare
caacbcb
to
82c4acf
Compare
Type of Change
Description
Described in #6524
This PR includes below changes
acl
field in the recon tokenAdditional Changes
Motivation and Context
Helps maintain and configure permissions for recon module granularly.
How did you test it?
acl
GET /verify_token
response to haveacl
Check /verify_token response
cURL
Response
Checklist
cargo +nightly fmt --all
cargo clippy