Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): add error handling wrapper to wehbook #6636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sakilmostak
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

In webhook, for specific connectors, we want to consume every webhook that arrives even if a error occurs while processing. This is done to keep the webhook channel open with the connector.
In this pr, a error wrapper is introduced to handle this logic where based on connector, we choose whether to send error or not.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sakilmostak Sakilmostak added A-core Area: Core flows C-refactor Category: Refactor A-webhooks Area: Webhook flows labels Nov 21, 2024
@Sakilmostak Sakilmostak added this to the November 2024 Release milestone Nov 21, 2024
@Sakilmostak Sakilmostak self-assigned this Nov 21, 2024
@Sakilmostak Sakilmostak requested review from a team as code owners November 21, 2024 20:33
Copy link

semanticdiff-com bot commented Nov 21, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/webhooks/incoming.rs  25% smaller
  crates/api_models/src/connector_enums.rs  0% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows A-webhooks Area: Webhook flows C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant