feat(core): payments overcapture support for V1 #6824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperswitch-bot
bot
added
M-database-changes
AkshayaFoiger
changed the title
AkshayaFoiger
force-pushed
the
over-capture
branch
from
61fe94c to
1c1510f
Compare
Comment on lines
2609
to
2612
| pub(crate) fn validate_amount_to_capture( | ||
| amount: i64, | ||
| amount_to_capture: Option<i64>, | ||
| is_overcapture_applied: Option<bool>, |
There was a problem hiding this comment.
But amount_to_capture must not be greater than amount_capturable right?
hrithikesh026
previously approved these changes
Jan 17, 2025
deepanshu-iiitu
previously approved these changes
Jan 17, 2025
sagarnaikjuspay
previously approved these changes
Jan 17, 2025
ThisIsMani
previously approved these changes
Jan 17, 2025
crates/api_models/src/admin.rs
Outdated
| @@ -2370,6 +2378,10 @@ pub struct ProfileUpdate { | |||
| /// Product authentication ids | |||
| #[schema(value_type = Option<Object>, example = r#"{ "key1": "value-1", "key2": "value-2" }"#)] | |||
| pub authentication_product_ids: Option<HashMap<String, id_type::MerchantConnectorAccountId>>, | |||
|
|
|||
| /// Indicates if the overcapture is always requested or not. | |||
| #[schema(default = false, example = false)] | |||
There was a problem hiding this comment.
There's no default false during ProfileUpdate
| request_overcapture: Option<api_enums::OverCaptureRequest>, | ||
| ) -> Result<(), errors::ApiErrorResponse> { | ||
| utils::when( | ||
| request_overcapture == Some(api_enums::OverCaptureRequest::Enable) |
There was a problem hiding this comment.
We can have impl based fns for these checks, something like request_overcapture.is_enabled() && !capture_method.is_manual()
|
|
||
| /// Get the boolean value of the `OverCaptureStatus`. | ||
| impl super::OverCaptureStatus { | ||
| pub fn as_bool(&self) -> bool { |
There was a problem hiding this comment.
All of this bool conversions could simply be impl based fns, something like OverCaptureStatus::is_applicable()
| @@ -1158,7 +1160,7 @@ impl PaymentCreate { | |||
| }) | |||
| .ok() | |||
| }) | |||
| .and_then(|pmd| match pmd { | |||
| .and_then(|pmd: PaymentMethodsData| match pmd { | |||
There was a problem hiding this comment.
Is this change required?
There was a problem hiding this comment.
Not required, I will remove it
| .always_request_overcapture | ||
| .map(api_enums::OverCaptureRequest::from))), | ||
| Some(_) => { | ||
| match payment_attempt.request_overcapture { |
There was a problem hiding this comment.
what's the case we are trying to handle here?
There was a problem hiding this comment.
This handles the case where request_overcapture is enabled, but capture method is not manual
AkshayaFoiger
dismissed stale reviews from ThisIsMani, sagarnaikjuspay, deepanshu-iiitu, and hrithikesh026
via
d3ff1f3
sai-harsha-vardhan
previously approved these changes
Jan 22, 2025
ThisIsMani
approved these changes
Jan 22, 2025
hrithikesh026
approved these changes
Jan 22, 2025
sai-harsha-vardhan
approved these changes
Jan 22, 2025
deepanshu-iiitu
approved these changes
Jan 22, 2025
jarnura
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Overcapture allows you to capture with an amount that’s higher than the authorised amount for a card payment. Unlike incremental authorisations, overcapture doesn’t result in additional authorisations with the card networks.
Additional Changes
API contract changes:
a) /payments create request to include
request_overcapturebooleanb) /payments response to include
c) Profile create request and response to include
always_request_overcapture(boolean)d) Profile update request and response to include
always_request_overcapture(boolean)DB changes:
a) request_overcapture enum(Enable/Skip) field to be introduced in payment_intent
b)ovecapture_status enum(Applicable/NotApplicable) to be introduced in payment_attempt
d) always_request_overcapture boolean field to be introduced in business_profiles table
Not Handled (phase 2 )
a) Error is not thrown, when overcapture is not supported by the connector/capture_type
b) List of supported connector and payment method not maintained.
c) Extend this feature for multiple manual capture and incremental authorization
-> Cypress test not added because it cannot be tested, via stripe. As this functionality has to be enabled by stripe.
-> Supported only for stripe card flow
How did you test it?
"always_request_overcapture": trueResponse
DB - business_profile will have a field called always_request_overcapture , marked as
truerequest_overcapturein the payment request"always_request_overcapture": falseResponse
Response
Hardcoded testcases - cannot be tested in integ/sandbox/prod. These are tests triggered after hardcoding the amount values.
Response
Overcapture the authorized amount
Response
Refund
Response
Checklist
cargo +nightly fmt --allcargo clippy