Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): Update mandate PMT configs for Mandate Supported Connectors #6903

Merged
merged 6 commits into from
Dec 20, 2024
Merged

fix(connector): Update mandate PMT configs for Mandate Supported Connectors #6903

merged 6 commits into from
Dec 20, 2024

Conversation

awasthi21
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@awasthi21 awasthi21 added the M-configuration-changes Metadata: This PR involves configuration changes label Dec 19, 2024
@awasthi21 awasthi21 self-assigned this Dec 19, 2024
@awasthi21 awasthi21 requested a review from a team as a code owner December 19, 2024 15:42
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@awasthi21 awasthi21 changed the title fix(connector): [Stripe] Add mandate configs(Bacs,SEPA,Becs,ACH) for Stripe fix(connector): [Stripe] Update mandate configs for Mandate Supported Connectors Dec 19, 2024
@awasthi21 awasthi21 changed the title fix(connector): [Stripe] Update mandate configs for Mandate Supported Connectors fix(connector): [Stripe] Update mandate PMT configs for Mandate Supported Connectors Dec 19, 2024
@awasthi21 awasthi21 changed the title fix(connector): [Stripe] Update mandate PMT configs for Mandate Supported Connectors fix(connector): Update mandate PMT configs for Mandate Supported Connectors Dec 19, 2024
SanchithHegde
SanchithHegde reviewed Dec 20, 2024
View reviewed changes
config/development.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can remove the comments here. Optional change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

config/deployments/sandbox.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the same changes in integration_test.toml file as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes added

@awasthi21 awasthi21 force-pushed the 7920-fixconnector-stripe-fix-stripe-cit-configs branch from 87e0038 to ee5c08d Compare December 20, 2024 09:18
@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 02f0824 Dec 20, 2024
17 of 19 checks passed
@Gnanasundari24 Gnanasundari24 deleted the 7920-fixconnector-stripe-fix-stripe-cit-configs branch December 20, 2024 11:06
awasthi21 added a commit that referenced this pull request Dec 20, 2024
@awasthi21
fix(connector): Update mandate PMT configs for Mandate Supported Conn…
05ea065 
…ectors (#6903)
@awasthi21 awasthi21 mentioned this pull request Dec 20, 2024
Merged
14 tasks
pixincreate added a commit that referenced this pull request Dec 20, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into cypress-del…
4a28603 
…ete-pm

* 'main' of github.com:juspay/hyperswitch:
  fix(connector): Update mandate PMT configs for Mandate Supported Connectors (#6903)
  fix(connector): [STRIPE] fix stripe mandate (#6899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@awasthi21 awasthi21

Labels
M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awasthi21 @SanchithHegde @deepanshu-iiitu @Gnanasundari24