Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider status of payment method before filtering wallets in list pm #7007

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

Chethan-rao
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Main pr - #7004

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Chethan-rao Chethan-rao self-assigned this Jan 8, 2025
@Chethan-rao Chethan-rao requested a review from a team as a code owner January 8, 2025 07:24
Copy link

semanticdiff-com bot commented Jan 8, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/types/transformers.rs  79% smaller
  crates/api_models/src/payments.rs  76% smaller
  crates/common_enums/src/transformers.rs  73% smaller
  crates/common_utils/src/types/keymanager.rs  73% smaller
  crates/common_utils/src/types.rs  73% smaller
  crates/router/src/core/payment_methods/cards.rs  65% smaller
  crates/euclid/src/frontend/ast/parser.rs  34% smaller
  crates/router/src/connector/adyen/transformers.rs  33% smaller
  crates/router/src/core/payments.rs  22% smaller
  crates/masking/src/diesel.rs  18% smaller
  crates/router/src/services/kafka.rs  17% smaller
  crates/router/src/core/user.rs  10% smaller
  crates/masking/src/serde.rs  1% smaller
  crates/router/src/core/admin.rs  1% smaller
  crates/api_models/src/admin.rs  0% smaller
  crates/api_models/src/analytics.rs  0% smaller
  crates/api_models/src/api_keys.rs  0% smaller
  crates/api_models/src/enums.rs  0% smaller
  crates/api_models/src/pm_auth.rs  0% smaller
  crates/common_utils/src/custom_serde.rs  0% smaller
  crates/diesel_models/src/configs.rs  0% smaller
  crates/diesel_models/src/lib.rs  0% smaller
  crates/diesel_models/src/organization.rs  0% smaller
  crates/euclid/src/dssa/types.rs  0% smaller
  crates/euclid/src/frontend/ast/lowering.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/nexinets/transformers.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/razorpay/transformers.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/tsys/transformers.rs  0% smaller
  crates/hyperswitch_connectors/src/utils.rs  0% smaller
  crates/hyperswitch_domain_models/src/merchant_account.rs  0% smaller
  crates/hyperswitch_interfaces/src/secrets_interface.rs  0% smaller
  crates/masking/src/maskable.rs  0% smaller
  crates/router/src/connector/braintree/transformers.rs  0% smaller
  crates/router/src/connector/signifyd/transformers/api.rs  0% smaller
  crates/router/src/connector/utils.rs  0% smaller
  crates/router/src/core/routing.rs  0% smaller
  crates/router/src/core/routing/helpers.rs  0% smaller
  crates/router/src/routes/payments.rs  0% smaller
  crates/router/src/services/kafka/authentication.rs  0% smaller
  crates/router/src/services/kafka/authentication_event.rs  0% smaller
  crates/router/src/services/kafka/dispute.rs  0% smaller
  crates/router/src/services/kafka/dispute_event.rs  0% smaller
  crates/router/src/services/kafka/fraud_check.rs  0% smaller
  crates/router/src/services/kafka/fraud_check_event.rs  0% smaller
  crates/router/src/services/kafka/payment_attempt.rs  0% smaller
  crates/router/src/services/kafka/payment_attempt_event.rs  0% smaller
  crates/router/src/services/kafka/payment_intent.rs  0% smaller
  crates/router/src/services/kafka/payment_intent_event.rs  0% smaller
  crates/router/src/services/kafka/payout.rs  0% smaller
  crates/router/src/services/kafka/refund.rs  0% smaller
  crates/router/src/services/kafka/refund_event.rs  0% smaller
  crates/router_derive/src/lib.rs  0% smaller
  crates/router_env/src/logger/formatter.rs  0% smaller
  crates/storage_impl/src/redis/cache.rs  0% smaller
  crates/storage_impl/src/redis/kv_store.rs  0% smaller

@Chethan-rao Chethan-rao changed the base branch from hotfix-2024.11.13.0 to hotfix-2024.12.04.0 January 8, 2025 10:07
@Chethan-rao Chethan-rao requested review from a team as code owners January 8, 2025 10:07
@Chethan-rao Chethan-rao closed this Jan 8, 2025
@Chethan-rao Chethan-rao reopened this Jan 8, 2025
@Chethan-rao Chethan-rao changed the base branch from hotfix-2024.12.04.0 to hotfix-2024.11.13.0 January 8, 2025 11:23
jagan-jaya
jagan-jaya previously approved these changes Jan 8, 2025
Aprabhat19
Aprabhat19 previously approved these changes Jan 8, 2025
@Chethan-rao Chethan-rao dismissed stale reviews from Aprabhat19 and jagan-jaya via 5542355 January 8, 2025 14:13
@Chethan-rao Chethan-rao requested review from a team as code owners January 8, 2025 14:13
Copy link
Contributor

@racnan racnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dashboard changes looks okay.

@Gnanasundari24 Gnanasundari24 merged commit 57c6caa into hotfix-2024.11.13.0 Jan 9, 2025
15 of 18 checks passed
@Gnanasundari24 Gnanasundari24 deleted the hotfix_fix_pm_wallet_list branch January 9, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants