fix(multitenancy): add a fallback for get commands in redis

[dracarys18]

Type of Change

• Enhancement

Description

• Add a fallback for Redis gets with prefix
• Add a Domain type for Redis for the correctness of adding a prefix

Motivation and Context

To keep the tenant data isolated from each other, We are using a prefix for Redis keys i.e A key which would be saved as card123 without multitenancy would be saved as public:card123 with Multitenancy.
If the user makes a payment on the older pod where MultiTenancy is disabled and client_secret is saved without a prefix, Now if the confirm calls goes to the pod where Multitenancy is enabled the Payment would fail with Unauthorized. This is just one of the instances where the payments would fail.

How did you test it?

** THIS CANNOT BE TESTED ON HIGHER ENVIRONMENTS **

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/router/src/services/authorization.rs	97% smaller
crates/router/src/routes/payment_methods.rs	95% smaller
crates/router/src/core/payments/types.rs	95% smaller
crates/router/src/core/api_locking.rs	93% smaller
crates/router/src/core/payment_methods/vault.rs	92% smaller
crates/storage_impl/src/redis/cache.rs	92% smaller
crates/storage_impl/src/redis/kv_store.rs	89% smaller
crates/router/src/core/poll.rs	83% smaller
crates/drainer/src/stream.rs	81% smaller
crates/router/src/core/health_check.rs	75% smaller
crates/scheduler/src/utils.rs	75% smaller
crates/router/src/core/payment_methods/cards.rs	72% smaller
crates/router/src/utils/currency.rs	68% smaller
crates/router/src/db/ephemeral_key.rs	68% smaller
crates/scheduler/src/db/queue.rs	64% smaller
crates/drainer/src/health_check.rs	62% smaller
crates/router/src/services/authentication/blacklist.rs	56% smaller
crates/router/src/routes/dummy_connector/utils.rs	47% smaller
crates/router/src/core/payments/helpers.rs	26% smaller
crates/redis_interface/src/commands.rs	25% smaller
crates/router/src/core/payouts/helpers.rs	24% smaller
crates/router/src/services/openidconnect.rs	17% smaller
crates/router/src/utils/user/two_factor_auth.rs	17% smaller
crates/router/src/db/merchant_connector_account.rs	17% smaller
crates/router/src/core/payments.rs	16% smaller
crates/router/src/utils/user.rs	16% smaller
crates/router/src/core/pm_auth.rs	9% smaller
crates/redis_interface/Cargo.toml	Unsupported file format
crates/redis_interface/src/types.rs	0% smaller
crates/router/src/core/payments/operations/payment_confirm.rs	0% smaller
crates/router/src/core/webhooks/incoming.rs	0% smaller
crates/router/src/routes/dummy_connector/core.rs	0% smaller
crates/router/tests/cache.rs	0% smaller
crates/storage_impl/src/lib.rs	0% smaller

[Chethan-rao]

Also why are none of the stream redis commands not having this fallback logic?

[dracarys18]

Also why are none of the stream redis commands not having this fallback logic?

Retrying streams is a little tricky because xread will not throw any error if the stream is empty obviously. And in this case the streams with prefix will mostly be empty. And only way to retry it is to drain from both the streams. And I am not sure what sort of problems that could come with it. So I think it's better to do that consciously rather than trying it in the code.