Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): address cybersource redirection inconsistency #7057

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Jan 17, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • cybsource ci checks have been failing randomly since yesterday. the point of failure had been redirection where it cannot find the input text field resulting in timeout
  • with this pr, i force the cypress to wait until the page loads completely
  • this is more sophisticated, reliable, and safer

closes #7058

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

ci checks

How did you test it?

this issue is not reproducible in local but only in github ci. so, the ci check should never fail!

image

Checklist

  • I formatted the code npm run format
  • I addressed lints thrown by npm run lint
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

force it to wait until the page loads. this is more sophisticated,
reliable, and safer
@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 17, 2025
@pixincreate pixincreate added this to the December 2024 Release milestone Jan 17, 2025
@pixincreate pixincreate self-assigned this Jan 17, 2025
Copy link

semanticdiff-com bot commented Jan 17, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/support/redirectionHandler.js  44% smaller
  cypress-tests/cypress/support/e2e.js  0% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix cybersource cypress redirection
1 participant