Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(CI): enable caching for check-v2 job #7166

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

refactor(CI): enable caching for check-v2 job #7166

wants to merge 13 commits into from

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Feb 3, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

minor refactor in ci-pr.yml and ci-push.yml files.
Other changes:
swatinem was considering all rust and cargo envs to calculate cache key which was unnecessary. Only CARGO_INCREMENTAL and RUSTFLAGS would affect the compiled artifacts.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Github CI checks

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hrithikesh026 hrithikesh026 self-assigned this Feb 3, 2025
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner February 3, 2025 08:06
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Feb 3, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/connector-ui-sanity-tests.yml  39% smaller
  .github/workflows/postman-collection-runner.yml  39% smaller
  .github/workflows/connector-sanity-tests.yml  38% smaller
  .github/workflows/CI-push.yml  27% smaller
  .github/workflows/CI-pr.yml  27% smaller

@hrithikesh026 hrithikesh026 changed the title enable caching in pr check feat: enable saving cache only in merge queue Feb 3, 2025
@hrithikesh026 hrithikesh026 changed the title feat: enable saving cache only in merge queue refactor(CI): enable caching for check-v2 job Feb 4, 2025
@hrithikesh026 hrithikesh026 added the A-CI-CD Area: Continuous Integration/Deployment label Feb 4, 2025
@hrithikesh026 hrithikesh026 linked an issue Feb 7, 2025 that may be closed by this pull request
[BUG] Swatinem is considering all rust related ENVs for cache key calculation #7207
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

At least 2 approving reviews are required to merge this pull request.

Assignees

@hrithikesh026 hrithikesh026

Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Swatinem is considering all rust related ENVs for cache key calculation
1 participant
@hrithikesh026