Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): Trait gating in v2 #7223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(v2): Trait gating in v2 #7223

wants to merge 2 commits into from
+5 −2

Conversation

Sarthak1799
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

The command just run_v2 errored out due to missing feature flags on Dynamic Routing trait.
This PR fixes that.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sarthak1799 Sarthak1799 self-assigned this Feb 8, 2025
@Sarthak1799 Sarthak1799 requested a review from a team as a code owner February 8, 2025 07:19
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Feb 8, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/routing/helpers.rs  0% smaller

@Sarthak1799 Sarthak1799 linked an issue Feb 8, 2025 that may be closed by this pull request
[BUG] Fix just run_v2 #7224
Open
2 tasks
@Sarthak1799 Sarthak1799 added C-bug Category: Bug api-v2 labels Feb 8, 2025
SanchithHegde
SanchithHegde previously approved these changes Feb 8, 2025
View reviewed changes
Narayanbhat166
Narayanbhat166 previously approved these changes Feb 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Chethan-rao Chethan-rao Chethan-rao approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 left review comments

Assignees

@Sarthak1799 Sarthak1799

Labels
api-v2 C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Fix just run_v2
4 participants
@Sarthak1799 @SanchithHegde @Narayanbhat166 @Chethan-rao